From: Tom Rini <trini@kernel•crashing.org>
To: Kumar Gala <kumar.gala@freescale•com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: Re: building ppc_htab?
Date: Thu, 17 Mar 2005 14:58:52 -0700 [thread overview]
Message-ID: <20050317215852.GJ8345@smtp.west.cox.net> (raw)
In-Reply-To: <20050317174137.GH8345@smtp.west.cox.net>
On Thu, Mar 17, 2005 at 10:41:37AM -0700, Tom Rini wrote:
> On Thu, Mar 17, 2005 at 11:34:14AM -0600, Kumar Gala wrote:
> >
> > On Mar 16, 2005, at 4:11 PM, Tom Rini wrote:
> >
> > >On Wed, Mar 16, 2005 at 12:57:24AM -0600, Kumar Gala wrote:
> > >
> > >> Is there any reason not to make the following change so we build
> > >> ppc_htab only on PPC STD MMU?? This would also require fixing up
> > >> fs/proc/proc_misc.c.
> > >
> > >I could have sworn, but maybe my memory sucks, that we no longer messed
> > >w/ fs/proc/proc_misc.c for any of the PPC-specific things (since in 2.6
> > > you can do all of that proc magic in your 'driver').? So this patch
> > > would make a great deal of sense to do, and if it lacks what I'm
> > >talking
> > > about, we should do that part as well :)
> >
> > I'm not exactly clear on what you are talking about. There is this
> > snippet in fs/proc/proc_misc.c:
>
> Crap :(
>
> > #ifdef CONFIG_PPC32
> > {
> > extern struct file_operations ppc_htab_operations;
> > entry = create_proc_entry("ppc_htab", S_IRUGO|S_IWUSR,
> > NULL);
> > if (entry)
> > entry->proc_fops = &ppc_htab_operations;
> > }
> > #endif
> >
> > Are you suggesting this should live elsewhere? I'm not that familiar
> > with proc code.
>
> Yes, it should live in ppc_htab.c. See the CONFIG_SYSCTL stuff already
> in ppc_htab.c for l2crvec.
Der, that's not the same thing! I still swear there's a way to do this
w/o messing w/ fs/proc/proc_misc.c, but I don't recall a good example.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-03-17 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 6:57 building ppc_htab? Kumar Gala
2005-03-16 17:12 ` Dan Malek
2005-03-16 22:11 ` Tom Rini
2005-03-17 17:34 ` Kumar Gala
2005-03-17 17:41 ` Tom Rini
2005-03-17 21:58 ` Tom Rini [this message]
2005-03-18 5:12 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050317215852.GJ8345@smtp.west.cox.net \
--to=trini@kernel$(echo .)crashing.org \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox