From: Marcelo Tosatti <marcelo.tosatti@cyclades•com>
To: Tom Rini <trini@kernel•crashing.org>
Cc: linux-ppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: [RFC] attempt to remove misc-embedded.c
Date: Mon, 25 Apr 2005 11:36:19 -0300 [thread overview]
Message-ID: <20050425143619.GF25420@logos.cnet> (raw)
In-Reply-To: <20050425145029.GD3112@smtp.west.cox.net>
On Mon, Apr 25, 2005 at 07:50:29AM -0700, Tom Rini wrote:
> On Wed, Apr 13, 2005 at 04:57:13PM -0300, Marcelo Tosatti wrote:
>
> >
> > Hi Tom,
> >
> > This is an attempt to move remove misc-embedded.c by moving its quirks to
> > misc.c.
> >
> > It needs further fixing and cleaning, for sure.
>
> I like the idea of deleting misc-embedded.c, but I don't think we should
> haven't make many changes to misc.c (except perhaps abstracting away a
> few more hunks of it) as I _think_ most of the cpu-specific stuff can be
> moved around now to the misc-board.c files.
So the plan is to move all cpu specific code in decompress_kernel() to cpu specific code :)
Including
#ifdef CONFIG_44x
/* Reset MAL */
mtdcr(DCRN_MALCR(DCRN_MAL_BASE), MALCR_MMSR);
/* Wait for reset */
while (mfdcr(DCRN_MALCR(DCRN_MAL_BASE)) & MALCR_MMSR) {};
/* Reset EMAC */
*(volatile unsigned long *)PPC44x_EMAC0_MR0 = 0x20000000;
__asm__ __volatile__("eieio");
#endif
There are a few changes which are required for embedded targets, for example, passing "bd"
to serial_init as its 2nd argument.
Some misc-embedded.c requirements also need to be there, in decompress_kernel().
For example
+#ifdef CONFIG_EMBEDDEDBOOT
+ /* Set end of memory available to us. It is always the highest
+ * memory address provided by the board information.
+ */
+ end_avail = (char *)(bp->bi_memsize);
+#else
/* assume the chunk below 8M is free */
end_avail = (char *)0x00800000;
+#endif
And later "end_avail" setting need to be abstracted away.
Is that what you mean?
> > Are there any major disagreements about the change?
> > Might need to define a bd_t structure for all ppc's?
>
> That's something to be left for the flat OF tree thread. :)
>
> --
> Tom Rini
> http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-04-25 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-13 19:57 [RFC] attempt to remove misc-embedded.c Marcelo Tosatti
2005-04-25 14:50 ` Tom Rini
2005-04-25 14:36 ` Marcelo Tosatti [this message]
2005-04-25 19:55 ` Eugene Surovegin
2005-04-25 14:59 ` Marcelo Tosatti
2005-04-25 20:26 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050425143619.GF25420@logos.cnet \
--to=marcelo.tosatti@cyclades$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=trini@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox