public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel•crashing.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades•com>
Cc: linux-ppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: [RFC] attempt to remove misc-embedded.c
Date: Mon, 25 Apr 2005 13:26:41 -0700	[thread overview]
Message-ID: <20050425202641.GD19245@smtp.west.cox.net> (raw)
In-Reply-To: <20050425145916.GA25998@logos.cnet>

On Mon, Apr 25, 2005 at 11:59:17AM -0300, Marcelo Tosatti wrote:
> On Mon, Apr 25, 2005 at 12:55:20PM -0700, Eugene Surovegin wrote:
> > On Mon, Apr 25, 2005 at 11:36:19AM -0300, Marcelo Tosatti wrote:
> > > So the plan is to move all cpu specific code in decompress_kernel() to cpu specific code :)
> > > 
> > > Including
> > > 
> > > #ifdef CONFIG_44x
> > >         /* Reset MAL */
> > >         mtdcr(DCRN_MALCR(DCRN_MAL_BASE), MALCR_MMSR);
> > >         /* Wait for reset */
> > >         while (mfdcr(DCRN_MALCR(DCRN_MAL_BASE)) & MALCR_MMSR) {};
> > >         /* Reset EMAC */
> > >         *(volatile unsigned long *)PPC44x_EMAC0_MR0 = 0x20000000;
> > >         __asm__ __volatile__("eieio");
> > > #endif
> > 
> > Hmm, strange, 2.4 has this code already moved to misc-44x.c, I wonder 
> > why this change never made it to 2.6.
> > 
> > Marcelo, I assume you are going to make this look like 2.4, right?
> 
> Sure, that looks better. 
> 
> Ok, so we can just make something minimal as misc-4xx, for 8xx, and 
> have everything which can be outside decompress_kernel() there.

Yes, I think we're starting to understand eachother, as that sounds like
what I was talking about.

-- 
Tom Rini
http://gate.crashing.org/~trini/

      reply	other threads:[~2005-04-25 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-13 19:57 [RFC] attempt to remove misc-embedded.c Marcelo Tosatti
2005-04-25 14:50 ` Tom Rini
2005-04-25 14:36   ` Marcelo Tosatti
2005-04-25 19:55     ` Eugene Surovegin
2005-04-25 14:59       ` Marcelo Tosatti
2005-04-25 20:26         ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050425202641.GD19245@smtp.west.cox.net \
    --to=trini@kernel$(echo .)crashing.org \
    --cc=linuxppc-embedded@ozlabs$(echo .)org \
    --cc=marcelo.tosatti@cyclades$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox