From: Sam Ravnborg <sam@ravnborg•org>
To: Kumar Gala <kumar.gala@freescale•com>
Cc: Tom Rini <trini@kernel•crashing.org>,
"<cpclark@xmission•com> <cpclark@xmission•com>"
<cpclark@xmission•com>,
Linux Kernel list <linux-kernel@vger•kernel.org>,
linuxppc-embedded list <linuxppc-embedded@ozlabs•org>
Subject: Re: PPC uImage build not reporting correctly
Date: Tue, 10 May 2005 06:28:28 +0200 [thread overview]
Message-ID: <20050510042828.GA8398@mars.ravnborg.org> (raw)
In-Reply-To: <b0aede90eb15562c0dd5a44c10d1b965@freescale.com>
On Mon, May 09, 2005 at 10:19:01AM -0500, Kumar Gala wrote:
>
> On May 6, 2005, at 6:22 PM, <cpclark@xmission•com> wrote:
>
> >On Fri, 6 May 2005, Kumar Gala wrote:
> > > I tried the following w/o success:
> > >
> >> $(obj)/uImage: $(obj)/vmlinux.gz
> >>???????? $(Q)rm -f $@
> > >???????? $(call if_changed,uimage)
> >>???????? @echo '? Image: $@' $(shell if [ -f $@ ]; then echo 'is
> >ready'; else
> > > echo 'not made'; fi)
> >
> >Couldn't you eliminate the ($shell ..) construct altogether, like
> >this?:
> >
> >$(obj)/uImage: $(obj)/vmlinux.gz
> >??????? $(Q)rm -f $@
> > ??????? $(call if_changed,uimage)
> >??????? @echo -n '? Image: $@'
> > ??????? @if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi
>
> Yes, and this seems to actually work.
>
> Sam, does this look reasonable to you. If so I will work up a patch.
Looks ok - but I do not see why use of $(shell ...) did not work out.
Please bring your working version forward.
Sam
next prev parent reply other threads:[~2005-05-10 4:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.63.0505061718380.6288@xmission.xmission.com>
2005-05-09 15:19 ` PPC uImage build not reporting correctly Kumar Gala
2005-05-10 4:28 ` Sam Ravnborg [this message]
2005-05-10 10:34 ` cpclark
2005-05-11 5:01 ` Sam Ravnborg
2005-05-10 15:14 Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2005-05-06 15:23 Kumar Gala
2005-05-06 21:45 ` Sam Ravnborg
2005-05-06 21:57 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050510042828.GA8398@mars.ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=cpclark@xmission$(echo .)com \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=trini@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox