Subject: Re: [PATCH 03/04] Freescale Ethernet combined driver

From: Matt Porter <[email-masked]>
Date: Tue, 10 May 2005 06:27:44 -0700

On Tue, May 10, 2005 at 08:13:48AM -0400, Dan Malek wrote:
> 
> On May 10, 2005, at 7:17 AM, Pantelis Antoniou wrote:
> 
> > This patch replace iopa use with virt_to_phys.
> 
> Not gonna work .....
> 
> When you map uncached on 8xx you get a new vmalloc()
> space.  The virt_to_xxx macros don't work on those addresses.
> You need to use the dma_consistent() function, stash the
> real physical address it returns and then use it where
> appropriate.

That and the use of virt_to_* and friends is deprecated by
the DMA API. You'll never get that upstream even if it were
a case where it did work.  That's a good thing to know for
anybody doing other drivers...

-Matt