* Re: [PATCH 3/3] Move all the very similar files [not found] <20050822141235.GA7110@austin.ibm.com> @ 2005-08-22 14:20 ` Kumar Gala 2005-08-22 15:01 ` Olof Johansson 2005-08-23 5:41 ` Benjamin Herrenschmidt 0 siblings, 2 replies; 10+ messages in thread From: Kumar Gala @ 2005-08-22 14:20 UTC (permalink / raw) To: Olof Johansson; +Cc: linuxppc-dev list, Stephen Rothwell, ppc64-dev On Aug 22, 2005, at 9:12 AM, Olof Johansson wrote: > On Mon, Aug 22, 2005 at 04:10:30PM +1000, Stephen Rothwell wrote: > >> This moves all the very similar files - either the ppc64 file >> included >> the ppc file or they differed in simple comments. >> > > [...] > >> include/asm-powerpc/pmac_feature.h | 379 >> > ++++++++++++++++++++++++++++++++++++ > >> include/asm-powerpc/pmac_low_i2c.h | 43 ++++ >> > > Since the need is considered big enough to create a hierarchy for > the code under arch/powerpc/, wouldn't something corresponding be a > good idea for the include files? Or do we want to clutter them with > all platform-specific files in one directory? I'm in agreement, but am wondering how many of the pmac specific headers could end up in arch/powerpc/platforms/pmac in the future. - kumar ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] Move all the very similar files 2005-08-22 14:20 ` [PATCH 3/3] Move all the very similar files Kumar Gala @ 2005-08-22 15:01 ` Olof Johansson 2005-08-23 5:41 ` Benjamin Herrenschmidt 1 sibling, 0 replies; 10+ messages in thread From: Olof Johansson @ 2005-08-22 15:01 UTC (permalink / raw) To: Kumar Gala; +Cc: Olof Johansson, Stephen Rothwell, linuxppc-dev list, ppc64-dev On Mon, Aug 22, 2005 at 09:20:10AM -0500, Kumar Gala wrote: > >Since the need is considered big enough to create a hierarchy for > >the code under arch/powerpc/, wouldn't something corresponding be a > >good idea for the include files? Or do we want to clutter them with > >all platform-specific files in one directory? > > I'm in agreement, but am wondering how many of the pmac specific > headers could end up in arch/powerpc/platforms/pmac in the future. Yeah, not sure -- I was thinking the same while I wrote that reply. There are some pSeries and iSeries files that could maybe be moved there too. -Olof ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] Move all the very similar files 2005-08-22 14:20 ` [PATCH 3/3] Move all the very similar files Kumar Gala 2005-08-22 15:01 ` Olof Johansson @ 2005-08-23 5:41 ` Benjamin Herrenschmidt 2005-08-23 7:31 ` Stephen Rothwell 1 sibling, 1 reply; 10+ messages in thread From: Benjamin Herrenschmidt @ 2005-08-23 5:41 UTC (permalink / raw) To: Kumar Gala; +Cc: Olof Johansson, linuxppc-dev list, ppc64-dev, Stephen Rothwell On Mon, 2005-08-22 at 09:20 -0500, Kumar Gala wrote: > On Aug 22, 2005, at 9:12 AM, Olof Johansson wrote: > > > On Mon, Aug 22, 2005 at 04:10:30PM +1000, Stephen Rothwell wrote: > > > >> This moves all the very similar files - either the ppc64 file > >> included > >> the ppc file or they differed in simple comments. > >> > > > > [...] > > > >> include/asm-powerpc/pmac_feature.h | 379 > >> > > ++++++++++++++++++++++++++++++++++++ > > > >> include/asm-powerpc/pmac_low_i2c.h | 43 ++++ > >> > > > > Since the need is considered big enough to create a hierarchy for > > the code under arch/powerpc/, wouldn't something corresponding be a > > good idea for the include files? Or do we want to clutter them with > > all platform-specific files in one directory? > > I'm in agreement, but am wondering how many of the pmac specific > headers could end up in arch/powerpc/platforms/pmac in the future. Most of the ones that are in include/asm* are there because drivers outside of arch/* use them. Ben. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] Move all the very similar files 2005-08-23 5:41 ` Benjamin Herrenschmidt @ 2005-08-23 7:31 ` Stephen Rothwell 2005-08-23 17:05 ` Kumar Gala 0 siblings, 1 reply; 10+ messages in thread From: Stephen Rothwell @ 2005-08-23 7:31 UTC (permalink / raw) To: Benjamin Herrenschmidt; +Cc: olof, linuxppc-dev, linuxppc64-dev [-- Attachment #1: Type: text/plain, Size: 7013 bytes --] On Tue, 23 Aug 2005 15:41:47 +1000 Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote: > > Most of the ones that are in include/asm* are there because drivers > outside of arch/* use them. Indeed. Here is the result of grepping for all of the .h files in patch 3 (minus the obvious noncontentious ones like errno.h ...): asm/dbdma.h ----------------------------------------------------------- arch/ppc/platforms/pmac_feature.c:#include <asm/dbdma.h> arch/ppc64/kernel/pmac_feature.c:#include <asm/dbdma.h> drivers/block/swim3.c:#include <asm/dbdma.h> drivers/ide/ppc/pmac.c:#include <asm/dbdma.h> drivers/media/video/planb.c:#include <asm/dbdma.h> drivers/media/video/planb.h:#include <asm/dbdma.h> drivers/net/bmac.c:#include <asm/dbdma.h> drivers/net/mace.c:#include <asm/dbdma.h> drivers/scsi/mac53c94.c:#include <asm/dbdma.h> drivers/scsi/mesh.c:#include <asm/dbdma.h> drivers/serial/pmac_zilog.c:#include <asm/dbdma.h> sound/oss/dmasound/dmasound_awacs.c:#include <asm/dbdma.h> sound/ppc/pmac.h:#include <asm/dbdma.h> ----------------------------------------------------------- asm/keylargo.h ----------------------------------------------------------- arch/ppc/platforms/pmac_cpufreq.c:#include <asm/keylargo.h> arch/ppc/platforms/pmac_feature.c:#include <asm/keylargo.h> arch/ppc/platforms/pmac_low_i2c.c:#include <asm/keylargo.h> arch/ppc/platforms/pmac_smp.c:#include <asm/keylargo.h> arch/ppc64/kernel/pmac_feature.c:#include <asm/keylargo.h> arch/ppc64/kernel/pmac_low_i2c.c:#include <asm/keylargo.h> arch/ppc64/kernel/pmac_smp.c:#include <asm/keylargo.h> drivers/macintosh/mediabay.c:#include <asm/keylargo.h> ----------------------------------------------------------- asm/macio.h ----------------------------------------------------------- drivers/macintosh/macio_asic.c:#include <asm/macio.h> drivers/macintosh/macio_sysfs.c:#include <asm/macio.h> drivers/macintosh/therm_pm72.c:#include <asm/macio.h> drivers/macintosh/therm_windtunnel.c:#include <asm/macio.h> drivers/net/bmac.c:#include <asm/macio.h> drivers/net/mace.c:#include <asm/macio.h> drivers/scsi/mac53c94.c:#include <asm/macio.h> drivers/scsi/mesh.c:#include <asm/macio.h> drivers/serial/pmac_zilog.c:#include <asm/macio.h> include/asm-powerpc/pmac_feature.h:#include <asm/macio.h> ----------------------------------------------------------- asm/of_device.h ----------------------------------------------------------- arch/ppc/platforms/pmac_setup.c:#include <asm/of_device.h> arch/ppc/syslib/of_device.c:#include <asm/of_device.h> arch/ppc64/kernel/maple_setup.c:#include <asm/of_device.h> arch/ppc64/kernel/of_device.c:#include <asm/of_device.h> arch/ppc64/kernel/pmac_setup.c:#include <asm/of_device.h> drivers/macintosh/therm_adt746x.c:#include <asm/of_device.h> drivers/macintosh/therm_pm72.c:#include <asm/of_device.h> drivers/macintosh/therm_windtunnel.c:#include <asm/of_device.h> drivers/video/platinumfb.c:#include <asm/of_device.h> include/asm-powerpc/macio.h:#include <asm/of_device.h> ----------------------------------------------------------- asm/parport.h ----------------------------------------------------------- drivers/parport/ChangeLog: * parport_pc.c (parport_pc_init): Moved from asm/parport.h. drivers/parport/parport_pc.c:#include <asm/parport.h> drivers/parport/parport_pc.c:/* This is called by parport_pc_find_nonpci_ports (in asm/parport.h) */ drivers/parport/parport_pc.c: /* ISA ports and whatever (see asm/parport.h). */ ----------------------------------------------------------- asm/pmac_feature.h ----------------------------------------------------------- arch/ppc/kernel/ppc_ksyms.c:#include <asm/pmac_feature.h> arch/ppc/kernel/setup.c:#include <asm/pmac_feature.h> arch/ppc/platforms/pmac_cpufreq.c:#include <asm/pmac_feature.h> arch/ppc/platforms/pmac_feature.c:#include <asm/pmac_feature.h> arch/ppc/platforms/pmac_pci.c:#include <asm/pmac_feature.h> arch/ppc/platforms/pmac_pic.c:#include <asm/pmac_feature.h> arch/ppc/platforms/pmac_setup.c:#include <asm/pmac_feature.h> arch/ppc/platforms/pmac_smp.c:#include <asm/pmac_feature.h> arch/ppc/xmon/start.c:#include <asm/pmac_feature.h> arch/ppc64/kernel/bpa_iommu.c:#include <asm/pmac_feature.h> arch/ppc64/kernel/pci_direct_iommu.c:#include <asm/pmac_feature.h> arch/ppc64/kernel/pmac_feature.c:#include <asm/pmac_feature.h> arch/ppc64/kernel/pmac_pci.c:#include <asm/pmac_feature.h> arch/ppc64/kernel/pmac_setup.c:#include <asm/pmac_feature.h> arch/ppc64/kernel/pmac_smp.c:#include <asm/pmac_feature.h> arch/ppc64/kernel/udbg.c:#include <asm/pmac_feature.h> drivers/block/swim3.c:#include <asm/pmac_feature.h> drivers/char/agp/uninorth-agp.c:#include <asm/pmac_feature.h> drivers/i2c/busses/i2c-keywest.c:#include <asm/pmac_feature.h> drivers/ide/ppc/pmac.c:#include <asm/pmac_feature.h> drivers/ieee1394/ohci1394.c:#include <asm/pmac_feature.h> drivers/macintosh/adbhid.c:#include <asm/pmac_feature.h> drivers/macintosh/macio_asic.c:#include <asm/pmac_feature.h> drivers/macintosh/mediabay.c:#include <asm/pmac_feature.h> drivers/macintosh/smu.c:#include <asm/pmac_feature.h> drivers/macintosh/via-pmu.c:#include <asm/pmac_feature.h> drivers/net/bmac.c:#include <asm/pmac_feature.h> drivers/net/sungem.c:#include <asm/pmac_feature.h> drivers/net/wireless/airport.c:#include <asm/pmac_feature.h> drivers/scsi/mesh.c:#include <asm/pmac_feature.h> drivers/serial/pmac_zilog.c:#include <asm/pmac_feature.h> drivers/usb/host/ohci-pci.c:#include <asm/pmac_feature.h> drivers/video/aty/aty128fb.c:#include <asm/pmac_feature.h> drivers/video/aty/radeon_pm.c:#include <asm/pmac_feature.h> sound/oss/dmasound/dmasound_awacs.c:#include <asm/pmac_feature.h> sound/ppc/pmac.c:#include <asm/pmac_feature.h> sound/ppc/toonie.c:#include <asm/pmac_feature.h> sound/ppc/tumbler.c:#include <asm/pmac_feature.h> ----------------------------------------------------------- asm/pmac_low_i2c.h ----------------------------------------------------------- arch/ppc/platforms/pmac_feature.c:#include <asm/pmac_low_i2c.h> arch/ppc/platforms/pmac_low_i2c.c:#include <asm/pmac_low_i2c.h> arch/ppc64/kernel/pmac_feature.c:#include <asm/pmac_low_i2c.h> arch/ppc64/kernel/pmac_low_i2c.c:#include <asm/pmac_low_i2c.h> arch/ppc64/kernel/pmac_smp.c:#include <asm/pmac_low_i2c.h> drivers/i2c/busses/i2c-keywest.c:#include <asm/pmac_low_i2c.h> ----------------------------------------------------------- asm/uninorth.h ----------------------------------------------------------- arch/ppc/platforms/pmac_feature.c:#include <asm/uninorth.h> arch/ppc/platforms/pmac_low_i2c.c:#include <asm/uninorth.h> arch/ppc64/kernel/pmac_feature.c:#include <asm/uninorth.h> arch/ppc64/kernel/pmac_low_i2c.c:#include <asm/uninorth.h> drivers/char/agp/uninorth-agp.c:#include <asm/uninorth.h> ----------------------------------------------------------- -- Cheers, Stephen Rothwell sfr@canb•auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] Move all the very similar files 2005-08-23 7:31 ` Stephen Rothwell @ 2005-08-23 17:05 ` Kumar Gala 2005-08-24 18:20 ` Tom Rini 0 siblings, 1 reply; 10+ messages in thread From: Kumar Gala @ 2005-08-23 17:05 UTC (permalink / raw) To: Stephen Rothwell; +Cc: olof, linuxppc64-dev, linuxppc-dev On Aug 23, 2005, at 2:31 AM, Stephen Rothwell wrote: > On Tue, 23 Aug 2005 15:41:47 +1000 Benjamin Herrenschmidt > <benh@kernel•crashing.org> wrote: > >> >> Most of the ones that are in include/asm* are there because drivers >> outside of arch/* use them. >> > > Indeed. Here is the result of grepping for all of the .h files in > patch 3 (minus the > obvious noncontentious ones like errno.h ...): This seems reasonable then to have them in include/asm-powerpc. I feel that there are a few files in include/asm-ppc that were only used by code in arch/ppc/platforms but I'm probably just crazy. - kumar ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] Move all the very similar files 2005-08-23 17:05 ` Kumar Gala @ 2005-08-24 18:20 ` Tom Rini 2005-08-24 20:03 ` Arnd Bergmann 0 siblings, 1 reply; 10+ messages in thread From: Tom Rini @ 2005-08-24 18:20 UTC (permalink / raw) To: Kumar Gala; +Cc: olof, Stephen Rothwell, linuxppc-dev, linuxppc64-dev On Tue, Aug 23, 2005 at 12:05:36PM -0500, Kumar Gala wrote: > > On Aug 23, 2005, at 2:31 AM, Stephen Rothwell wrote: > > >On Tue, 23 Aug 2005 15:41:47 +1000 Benjamin Herrenschmidt > ><benh@kernel•crashing.org> wrote: > > > >> > >>Most of the ones that are in include/asm* are there because drivers > >>outside of arch/* use them. > >> > > > >Indeed. Here is the result of grepping for all of the .h files in > >patch 3 (minus the > >obvious noncontentious ones like errno.h ...): > > This seems reasonable then to have them in include/asm-powerpc. I No it doesn't. You can easily make the drivers get the includes from <platforms/pmac/foo.h>, arch/$(ARCH) is already always in the search path, I believe (if not, it's easy to add Makefile things to get it). -- Tom Rini http://gate.crashing.org/~trini/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] Move all the very similar files 2005-08-24 18:20 ` Tom Rini @ 2005-08-24 20:03 ` Arnd Bergmann 2005-08-24 20:13 ` Tom Rini 0 siblings, 1 reply; 10+ messages in thread From: Arnd Bergmann @ 2005-08-24 20:03 UTC (permalink / raw) To: linuxppc64-dev; +Cc: linuxppc-dev, Tom Rini, Stephen Rothwell On Middeweken 24 August 2005 20:20, Tom Rini wrote: > On Tue, Aug 23, 2005 at 12:05:36PM -0500, Kumar Gala wrote: > > > > This seems reasonable then to have them in include/asm-powerpc. I > > No it doesn't. You can easily make the drivers get the includes from > <platforms/pmac/foo.h>, arch/$(ARCH) is already always in the search > path, I believe (if not, it's easy to add Makefile things to get it). I don't think any architecture except ppc32 has traditionally had arch/$ARCH in its include path, and it would probably come as a surprise to many kernel developers if this were used more. Currently, there seem to be hardly any users of this "feature" in ppc32 that can't be trivially converted to including local files, so I'd rather not see this moved over to arch/powerpc. Arnd <>< ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] Move all the very similar files 2005-08-24 20:03 ` Arnd Bergmann @ 2005-08-24 20:13 ` Tom Rini 2005-08-24 20:44 ` Brad Boyer 0 siblings, 1 reply; 10+ messages in thread From: Tom Rini @ 2005-08-24 20:13 UTC (permalink / raw) To: Arnd Bergmann; +Cc: linuxppc-dev, linuxppc64-dev, Stephen Rothwell On Wed, Aug 24, 2005 at 10:03:26PM +0200, Arnd Bergmann wrote: > On Middeweken 24 August 2005 20:20, Tom Rini wrote: > > On Tue, Aug 23, 2005 at 12:05:36PM -0500, Kumar Gala wrote: > > > > > > This seems reasonable then to have them in include/asm-powerpc. I > > > > No it doesn't. You can easily make the drivers get the includes from > > <platforms/pmac/foo.h>, arch/$(ARCH) is already always in the search > > path, I believe (if not, it's easy to add Makefile things to get it). > > I don't think any architecture except ppc32 has traditionally had > arch/$ARCH in its include path, and it would probably come as a surprise > to many kernel developers if this were used more. True, but it's possible that the pmac drivers could also be converted to use something else to pass around infos, register IO and such so the headers can still live in arch/powerpc/platforms/pmac/ -- Tom Rini http://gate.crashing.org/~trini/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] Move all the very similar files 2005-08-24 20:13 ` Tom Rini @ 2005-08-24 20:44 ` Brad Boyer 0 siblings, 0 replies; 10+ messages in thread From: Brad Boyer @ 2005-08-24 20:44 UTC (permalink / raw) To: Tom Rini Cc: Linux/m68k on Mac, linuxppc-dev, Stephen Rothwell, Arnd Bergmann, linuxppc64-dev On Wed, Aug 24, 2005 at 01:13:32PM -0700, Tom Rini wrote: > On Wed, Aug 24, 2005 at 10:03:26PM +0200, Arnd Bergmann wrote: > > On Middeweken 24 August 2005 20:20, Tom Rini wrote: > > > No it doesn't. You can easily make the drivers get the includes from > > > <platforms/pmac/foo.h>, arch/$(ARCH) is already always in the search > > > path, I believe (if not, it's easy to add Makefile things to get it). > > > > I don't think any architecture except ppc32 has traditionally had > > arch/$ARCH in its include path, and it would probably come as a surprise > > to many kernel developers if this were used more. > > True, but it's possible that the pmac drivers could also be converted to > use something else to pass around infos, register IO and such so the > headers can still live in arch/powerpc/platforms/pmac/ These days, the macio bus is a real device-model bus. The code still lives in drivers/macintosh, but it will be used by more than just pmac machines whenever I get the 68k mac support finished. It seems like we really should have an include/linux/macio.h, and make the whole thing act more like a normal bus. I would like to abstract out more of it anyway, particularly the DMA support. That way we wouldn't have several different drivers for the same chip due to bus interface differences (see mace.c and macmace.c for an example of current practice). This would eliminate at least macio.h and dbdma.h. Hopefully it would get most of the mac specific code organized in a more logical fashion. Any comments/requirements/suggestions? Brad Boyer flar@allandria•com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] Create include/asm-powerpc
@ 2005-08-22 6:02 Stephen Rothwell
2005-08-22 6:05 ` [PATCH 2/3] Move the identical files from include/asm-ppc{,64} Stephen Rothwell
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2005-08-22 6:02 UTC (permalink / raw)
To: ppc64-dev
Hopefully, we can gree to start like this ...
Create include/asm-powerpc (and move linkage.h into it since we don't
like empty directories). Modify the Makefiles to cope.
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
arch/ppc/Makefile | 11 ++++++++++-
arch/ppc64/Makefile | 9 +++++++++
include/asm-powerpc/linkage.h | 6 ++++++
include/asm-ppc/linkage.h | 6 ------
include/asm-ppc64/linkage.h | 6 ------
5 files changed, 25 insertions(+), 13 deletions(-)
create mode 100644 include/asm-powerpc/linkage.h
delete mode 100644 include/asm-ppc/linkage.h
delete mode 100644 include/asm-ppc64/linkage.h
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
--- a/arch/ppc/Makefile
+++ b/arch/ppc/Makefile
@@ -21,11 +21,13 @@ CC := $(CC) -m32
endif
LDFLAGS_vmlinux := -Ttext $(KERNELLOAD) -Bstatic
-CPPFLAGS += -Iarch/$(ARCH)
+CPPFLAGS += -Iarch/$(ARCH) -Iinclude3
AFLAGS += -Iarch/$(ARCH)
CFLAGS += -Iarch/$(ARCH) -msoft-float -pipe \
-ffixed-r2 -mmultiple
CPP = $(CC) -E $(CFLAGS)
+# Temporary hack until we have migrated to asm-powerpc
+LINUXINCLUDE += -Iinclude3
CHECKFLAGS += -D__powerpc__
@@ -101,6 +103,7 @@ endef
archclean:
$(Q)$(MAKE) $(clean)=arch/ppc/boot
+ $(Q)rm -rf include3
prepare: include/asm-$(ARCH)/offsets.h checkbin
@@ -110,6 +113,12 @@ arch/$(ARCH)/kernel/asm-offsets.s: inclu
include/asm-$(ARCH)/offsets.h: arch/$(ARCH)/kernel/asm-offsets.s
$(call filechk,gen-asm-offsets)
+# Temporary hack until we have migrated to asm-powerpc
+include/asm: include3/asm
+include3/asm:
+ $(Q)if [ ! -d include3 ]; then mkdir -p include3; fi
+ $(Q)ln -fsn $(srctree)/include/asm-powerpc include3/asm
+
# Use the file '.tmp_gas_check' for binutils tests, as gas won't output
# to stdout and these checks are run even on install targets.
TOUT := .tmp_gas_check
diff --git a/arch/ppc64/Makefile b/arch/ppc64/Makefile
--- a/arch/ppc64/Makefile
+++ b/arch/ppc64/Makefile
@@ -55,6 +55,8 @@ LDFLAGS := -m elf64ppc
LDFLAGS_vmlinux := -Bstatic -e $(KERNELLOAD) -Ttext $(KERNELLOAD)
CFLAGS += -msoft-float -pipe -mminimal-toc -mtraceback=none \
-mcall-aixdesc
+# Temporary hack until we have migrated to asm-powerpc
+CPPFLAGS += -Iinclude3
GCC_VERSION := $(call cc-version)
GCC_BROKEN_VEC := $(shell if [ $(GCC_VERSION) -lt 0400 ] ; then echo "y"; fi ;)
@@ -112,6 +114,7 @@ all: $(KBUILD_IMAGE)
archclean:
$(Q)$(MAKE) $(clean)=$(boot)
+ $(Q)rm -rf include3
prepare: include/asm-ppc64/offsets.h
@@ -121,6 +124,12 @@ arch/ppc64/kernel/asm-offsets.s: include
include/asm-ppc64/offsets.h: arch/ppc64/kernel/asm-offsets.s
$(call filechk,gen-asm-offsets)
+# Temporary hack until we have migrated to asm-powerpc
+include/asm: include3/asm
+include3/asm:
+ $(Q)if [ ! -d include3 ]; then mkdir -p include3; fi;
+ $(Q)ln -fsn $(srctree)/include/asm-powerpc include3/asm
+
define archhelp
echo '* zImage - Compressed kernel image (arch/$(ARCH)/boot/zImage)'
echo ' zImage.initrd- Compressed kernel image with initrd attached,'
diff --git a/include/asm-powerpc/linkage.h b/include/asm-powerpc/linkage.h
new file mode 100644
--- /dev/null
+++ b/include/asm-powerpc/linkage.h
@@ -0,0 +1,6 @@
+#ifndef __ASM_LINKAGE_H
+#define __ASM_LINKAGE_H
+
+/* Nothing to see here... */
+
+#endif
diff --git a/include/asm-ppc/linkage.h b/include/asm-ppc/linkage.h
deleted file mode 100644
--- a/include/asm-ppc/linkage.h
+++ /dev/null
@@ -1,6 +0,0 @@
-#ifndef __ASM_LINKAGE_H
-#define __ASM_LINKAGE_H
-
-/* Nothing to see here... */
-
-#endif
diff --git a/include/asm-ppc64/linkage.h b/include/asm-ppc64/linkage.h
deleted file mode 100644
--- a/include/asm-ppc64/linkage.h
+++ /dev/null
@@ -1,6 +0,0 @@
-#ifndef __ASM_LINKAGE_H
-#define __ASM_LINKAGE_H
-
-/* Nothing to see here... */
-
-#endif
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 2/3] Move the identical files from include/asm-ppc{,64} 2005-08-22 6:02 [PATCH 1/3] Create include/asm-powerpc Stephen Rothwell @ 2005-08-22 6:05 ` Stephen Rothwell 2005-08-22 6:10 ` [PATCH 3/3] Move all the very similar files Stephen Rothwell 0 siblings, 1 reply; 10+ messages in thread From: Stephen Rothwell @ 2005-08-22 6:05 UTC (permalink / raw) To: ppc64-dev Move the identical files from include/asm-ppc{,64}/ to include/asm-powerpc/. Remove hdreg.h completely as it is unused in the tree. Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au> --- include/asm-powerpc/8253pit.h | 10 ++++++++++ include/asm-powerpc/agp.h | 23 +++++++++++++++++++++++ include/asm-powerpc/cputime.h | 1 + include/asm-powerpc/div64.h | 1 + include/asm-powerpc/emergency-restart.h | 1 + include/asm-powerpc/ipc.h | 1 + include/asm-powerpc/xor.h | 1 + include/asm-ppc/8253pit.h | 10 ---------- include/asm-ppc/agp.h | 23 ----------------------- include/asm-ppc/cputime.h | 6 ------ include/asm-ppc/div64.h | 1 - include/asm-ppc/emergency-restart.h | 6 ------ include/asm-ppc/hdreg.h | 1 - include/asm-ppc/ipc.h | 1 - include/asm-ppc/xor.h | 1 - include/asm-ppc64/8253pit.h | 10 ---------- include/asm-ppc64/agp.h | 23 ----------------------- include/asm-ppc64/cputime.h | 6 ------ include/asm-ppc64/div64.h | 1 - include/asm-ppc64/emergency-restart.h | 6 ------ include/asm-ppc64/hdreg.h | 1 - include/asm-ppc64/ipc.h | 1 - include/asm-ppc64/xor.h | 1 - 23 files changed, 38 insertions(+), 98 deletions(-) -- Cheers, Stephen Rothwell sfr@canb•auug.org.au http://www.canb.auug.org.au/~sfr/ diff --git a/include/asm-powerpc/8253pit.h b/include/asm-powerpc/8253pit.h new file mode 100644 --- /dev/null +++ b/include/asm-powerpc/8253pit.h @@ -0,0 +1,10 @@ +/* + * 8253/8254 Programmable Interval Timer + */ + +#ifndef _8253PIT_H +#define _8253PIT_H + +#define PIT_TICK_RATE 1193182UL + +#endif diff --git a/include/asm-powerpc/agp.h b/include/asm-powerpc/agp.h new file mode 100644 --- /dev/null +++ b/include/asm-powerpc/agp.h @@ -0,0 +1,23 @@ +#ifndef AGP_H +#define AGP_H 1 + +#include <asm/io.h> + +/* nothing much needed here */ + +#define map_page_into_agp(page) +#define unmap_page_from_agp(page) +#define flush_agp_mappings() +#define flush_agp_cache() mb() + +/* Convert a physical address to an address suitable for the GART. */ +#define phys_to_gart(x) (x) +#define gart_to_phys(x) (x) + +/* GATT allocation. Returns/accepts GATT kernel virtual address. */ +#define alloc_gatt_pages(order) \ + ((char *)__get_free_pages(GFP_KERNEL, (order))) +#define free_gatt_pages(table, order) \ + free_pages((unsigned long)(table), (order)) + +#endif diff --git a/include/asm-powerpc/cputime.h b/include/asm-powerpc/cputime.h new file mode 100644 --- /dev/null +++ b/include/asm-powerpc/cputime.h @@ -0,0 +1 @@ +#include <asm-generic/cputime.h> diff --git a/include/asm-powerpc/div64.h b/include/asm-powerpc/div64.h new file mode 100644 --- /dev/null +++ b/include/asm-powerpc/div64.h @@ -0,0 +1 @@ +#include <asm-generic/div64.h> diff --git a/include/asm-powerpc/emergency-restart.h b/include/asm-powerpc/emergency-restart.h new file mode 100644 --- /dev/null +++ b/include/asm-powerpc/emergency-restart.h @@ -0,0 +1 @@ +#include <asm-generic/emergency-restart.h> diff --git a/include/asm-powerpc/ipc.h b/include/asm-powerpc/ipc.h new file mode 100644 --- /dev/null +++ b/include/asm-powerpc/ipc.h @@ -0,0 +1 @@ +#include <asm-generic/ipc.h> diff --git a/include/asm-powerpc/xor.h b/include/asm-powerpc/xor.h new file mode 100644 --- /dev/null +++ b/include/asm-powerpc/xor.h @@ -0,0 +1 @@ +#include <asm-generic/xor.h> diff --git a/include/asm-ppc/8253pit.h b/include/asm-ppc/8253pit.h deleted file mode 100644 --- a/include/asm-ppc/8253pit.h +++ /dev/null @@ -1,10 +0,0 @@ -/* - * 8253/8254 Programmable Interval Timer - */ - -#ifndef _8253PIT_H -#define _8253PIT_H - -#define PIT_TICK_RATE 1193182UL - -#endif diff --git a/include/asm-ppc/agp.h b/include/asm-ppc/agp.h deleted file mode 100644 --- a/include/asm-ppc/agp.h +++ /dev/null @@ -1,23 +0,0 @@ -#ifndef AGP_H -#define AGP_H 1 - -#include <asm/io.h> - -/* nothing much needed here */ - -#define map_page_into_agp(page) -#define unmap_page_from_agp(page) -#define flush_agp_mappings() -#define flush_agp_cache() mb() - -/* Convert a physical address to an address suitable for the GART. */ -#define phys_to_gart(x) (x) -#define gart_to_phys(x) (x) - -/* GATT allocation. Returns/accepts GATT kernel virtual address. */ -#define alloc_gatt_pages(order) \ - ((char *)__get_free_pages(GFP_KERNEL, (order))) -#define free_gatt_pages(table, order) \ - free_pages((unsigned long)(table), (order)) - -#endif diff --git a/include/asm-ppc/cputime.h b/include/asm-ppc/cputime.h deleted file mode 100644 --- a/include/asm-ppc/cputime.h +++ /dev/null @@ -1,6 +0,0 @@ -#ifndef __PPC_CPUTIME_H -#define __PPC_CPUTIME_H - -#include <asm-generic/cputime.h> - -#endif /* __PPC_CPUTIME_H */ diff --git a/include/asm-ppc/div64.h b/include/asm-ppc/div64.h deleted file mode 100644 --- a/include/asm-ppc/div64.h +++ /dev/null @@ -1 +0,0 @@ -#include <asm-generic/div64.h> diff --git a/include/asm-ppc/emergency-restart.h b/include/asm-ppc/emergency-restart.h deleted file mode 100644 --- a/include/asm-ppc/emergency-restart.h +++ /dev/null @@ -1,6 +0,0 @@ -#ifndef _ASM_EMERGENCY_RESTART_H -#define _ASM_EMERGENCY_RESTART_H - -#include <asm-generic/emergency-restart.h> - -#endif /* _ASM_EMERGENCY_RESTART_H */ diff --git a/include/asm-ppc/hdreg.h b/include/asm-ppc/hdreg.h deleted file mode 100644 --- a/include/asm-ppc/hdreg.h +++ /dev/null @@ -1 +0,0 @@ -#include <asm-generic/hdreg.h> diff --git a/include/asm-ppc/ipc.h b/include/asm-ppc/ipc.h deleted file mode 100644 --- a/include/asm-ppc/ipc.h +++ /dev/null @@ -1 +0,0 @@ -#include <asm-generic/ipc.h> diff --git a/include/asm-ppc/xor.h b/include/asm-ppc/xor.h deleted file mode 100644 --- a/include/asm-ppc/xor.h +++ /dev/null @@ -1 +0,0 @@ -#include <asm-generic/xor.h> diff --git a/include/asm-ppc64/8253pit.h b/include/asm-ppc64/8253pit.h deleted file mode 100644 --- a/include/asm-ppc64/8253pit.h +++ /dev/null @@ -1,10 +0,0 @@ -/* - * 8253/8254 Programmable Interval Timer - */ - -#ifndef _8253PIT_H -#define _8253PIT_H - -#define PIT_TICK_RATE 1193182UL - -#endif diff --git a/include/asm-ppc64/agp.h b/include/asm-ppc64/agp.h deleted file mode 100644 --- a/include/asm-ppc64/agp.h +++ /dev/null @@ -1,23 +0,0 @@ -#ifndef AGP_H -#define AGP_H 1 - -#include <asm/io.h> - -/* nothing much needed here */ - -#define map_page_into_agp(page) -#define unmap_page_from_agp(page) -#define flush_agp_mappings() -#define flush_agp_cache() mb() - -/* Convert a physical address to an address suitable for the GART. */ -#define phys_to_gart(x) (x) -#define gart_to_phys(x) (x) - -/* GATT allocation. Returns/accepts GATT kernel virtual address. */ -#define alloc_gatt_pages(order) \ - ((char *)__get_free_pages(GFP_KERNEL, (order))) -#define free_gatt_pages(table, order) \ - free_pages((unsigned long)(table), (order)) - -#endif diff --git a/include/asm-ppc64/cputime.h b/include/asm-ppc64/cputime.h deleted file mode 100644 --- a/include/asm-ppc64/cputime.h +++ /dev/null @@ -1,6 +0,0 @@ -#ifndef __PPC_CPUTIME_H -#define __PPC_CPUTIME_H - -#include <asm-generic/cputime.h> - -#endif /* __PPC_CPUTIME_H */ diff --git a/include/asm-ppc64/div64.h b/include/asm-ppc64/div64.h deleted file mode 100644 --- a/include/asm-ppc64/div64.h +++ /dev/null @@ -1 +0,0 @@ -#include <asm-generic/div64.h> diff --git a/include/asm-ppc64/emergency-restart.h b/include/asm-ppc64/emergency-restart.h deleted file mode 100644 --- a/include/asm-ppc64/emergency-restart.h +++ /dev/null @@ -1,6 +0,0 @@ -#ifndef _ASM_EMERGENCY_RESTART_H -#define _ASM_EMERGENCY_RESTART_H - -#include <asm-generic/emergency-restart.h> - -#endif /* _ASM_EMERGENCY_RESTART_H */ diff --git a/include/asm-ppc64/hdreg.h b/include/asm-ppc64/hdreg.h deleted file mode 100644 --- a/include/asm-ppc64/hdreg.h +++ /dev/null @@ -1 +0,0 @@ -#include <asm-generic/hdreg.h> diff --git a/include/asm-ppc64/ipc.h b/include/asm-ppc64/ipc.h deleted file mode 100644 --- a/include/asm-ppc64/ipc.h +++ /dev/null @@ -1 +0,0 @@ -#include <asm-generic/ipc.h> diff --git a/include/asm-ppc64/xor.h b/include/asm-ppc64/xor.h deleted file mode 100644 --- a/include/asm-ppc64/xor.h +++ /dev/null @@ -1 +0,0 @@ -#include <asm-generic/xor.h> ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] Move all the very similar files 2005-08-22 6:05 ` [PATCH 2/3] Move the identical files from include/asm-ppc{,64} Stephen Rothwell @ 2005-08-22 6:10 ` Stephen Rothwell 0 siblings, 0 replies; 10+ messages in thread From: Stephen Rothwell @ 2005-08-22 6:10 UTC (permalink / raw) To: ppc64-dev This moves all the very similar files - either the ppc64 file included the ppc file or they differed in simple comments. Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au> --- This patch is too large for the list, so it is available at http://ozlabs.org/~sfr/0003-This-moves-all-the-very-similar-files-either-the-ppc64-file-included.txt include/asm-powerpc/dbdma.h | 102 ++++++++++ include/asm-powerpc/errno.h | 11 + include/asm-powerpc/ioctl.h | 69 +++++++ include/asm-powerpc/ioctls.h | 107 ++++++++++ include/asm-powerpc/keylargo.h | 248 ++++++++++++++++++++++++ include/asm-powerpc/local.h | 1 include/asm-powerpc/macio.h | 141 +++++++++++++ include/asm-powerpc/namei.h | 20 ++ include/asm-powerpc/of_device.h | 62 ++++++ include/asm-powerpc/parport.h | 18 ++ include/asm-powerpc/percpu.h | 1 include/asm-powerpc/pmac_feature.h | 379 ++++++++++++++++++++++++++++++++++++ include/asm-powerpc/pmac_low_i2c.h | 43 ++++ include/asm-powerpc/poll.h | 23 ++ include/asm-powerpc/resource.h | 1 include/asm-powerpc/shmparam.h | 6 + include/asm-powerpc/string.h | 32 +++ include/asm-powerpc/unaligned.h | 18 ++ include/asm-powerpc/uninorth.h | 229 ++++++++++++++++++++++ include/asm-ppc/dbdma.h | 102 ---------- include/asm-ppc/errno.h | 11 - include/asm-ppc/ioctl.h | 69 ------- include/asm-ppc/ioctls.h | 107 ---------- include/asm-ppc/keylargo.h | 248 ------------------------ include/asm-ppc/local.h | 6 - include/asm-ppc/macio.h | 141 ------------- include/asm-ppc/namei.h | 20 -- include/asm-ppc/of_device.h | 62 ------ include/asm-ppc/parport.h | 18 -- include/asm-ppc/percpu.h | 6 - include/asm-ppc/pmac_feature.h | 379 ------------------------------------ include/asm-ppc/pmac_low_i2c.h | 43 ---- include/asm-ppc/poll.h | 23 -- include/asm-ppc/resource.h | 6 - include/asm-ppc/shmparam.h | 6 - include/asm-ppc/string.h | 32 --- include/asm-ppc/unaligned.h | 18 -- include/asm-ppc/uninorth.h | 229 ---------------------- include/asm-ppc64/dbdma.h | 2 include/asm-ppc64/errno.h | 18 -- include/asm-ppc64/ioctl.h | 74 ------- include/asm-ppc64/ioctls.h | 114 ----------- include/asm-ppc64/keylargo.h | 2 include/asm-ppc64/local.h | 1 include/asm-ppc64/macio.h | 2 include/asm-ppc64/namei.h | 23 -- include/asm-ppc64/of_device.h | 2 include/asm-ppc64/parport.h | 18 -- include/asm-ppc64/percpu.h | 6 - include/asm-ppc64/pmac_feature.h | 2 include/asm-ppc64/pmac_low_i2c.h | 2 include/asm-ppc64/poll.h | 32 --- include/asm-ppc64/resource.h | 6 - include/asm-ppc64/shmparam.h | 13 - include/asm-ppc64/string.h | 35 --- include/asm-ppc64/unaligned.h | 21 -- include/asm-ppc64/uninorth.h | 2 57 files changed, 1511 insertions(+), 1901 deletions(-) -- Cheers, Stephen Rothwell sfr@canb•auug.org.au http://www.canb.auug.org.au/~sfr/ ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2005-08-24 20:44 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20050822141235.GA7110@austin.ibm.com>
2005-08-22 14:20 ` [PATCH 3/3] Move all the very similar files Kumar Gala
2005-08-22 15:01 ` Olof Johansson
2005-08-23 5:41 ` Benjamin Herrenschmidt
2005-08-23 7:31 ` Stephen Rothwell
2005-08-23 17:05 ` Kumar Gala
2005-08-24 18:20 ` Tom Rini
2005-08-24 20:03 ` Arnd Bergmann
2005-08-24 20:13 ` Tom Rini
2005-08-24 20:44 ` Brad Boyer
2005-08-22 6:02 [PATCH 1/3] Create include/asm-powerpc Stephen Rothwell
2005-08-22 6:05 ` [PATCH 2/3] Move the identical files from include/asm-ppc{,64} Stephen Rothwell
2005-08-22 6:10 ` [PATCH 3/3] Move all the very similar files Stephen Rothwell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox