Subject: Re: Marvell MV6436xx ethernet driver patch

From: Sven Luther <[email-masked]>
Date: Wed, 31 Aug 2005 11:47:29 +0200

On Wed, Aug 31, 2005 at 07:55:49AM +0100, Nicolas DET wrote:
> Hello Dale,
> > This is a good idea.  I suspect that most of the gain is from
> > turning off snooping and flushing/invalidating the cache explicitly.
> > Implementation-wise, I'd rather we not manipulate the MV643XX_ETH_BAR_?
> > registers directly in the driver.  Today that is done in platform
> > setup code.  This has promise but needs to be reworked.
> 
> Conclusion: yes, touching ETH_BAR isn't really well here, but where could
> we move it ?

What about : arch/ppc/plateform/chrp_pegasos_eth.c ?

Friendly,

Sven Luther