From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc64-dev@ozlabs•org
Cc: "linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>
Subject: Re: PATCH Merge more include files
Date: Fri, 2 Sep 2005 05:18:32 +0200 [thread overview]
Message-ID: <200509020518.32732.arnd@arndb.de> (raw)
In-Reply-To: <1125607912.16685.111.camel@cashmere.sps.mot.com>
On Dunnersdag 01 September 2005 22:51, Jon Loeliger wrote:
> +/*
> + * This file is included by 'init/main.c' to check for
> + * architecture-dependent bugs.
> + */
> +
> +extern void check_bugs(void);
> +
Actually, I think this could to be
+static inline void check_bugs(void)
+{
+}
The function is empty on both ppc and ppc64, so we can just as
well get rid of the symbol as well.
The rest of the patch looks perfect to me.
Arnd <><
next prev parent reply other threads:[~2005-09-02 3:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 20:51 PATCH Merge more include files Jon Loeliger
2005-09-02 3:18 ` Arnd Bergmann [this message]
2005-09-02 13:38 ` Kumar Gala
2005-09-06 20:46 ` Jon Loeliger
2005-09-06 22:14 ` Arnd Bergmann
2005-09-02 6:15 ` Stephen Rothwell
2005-09-02 6:37 ` Stephen Rothwell
2005-09-06 20:45 ` Jon Loeliger
2005-09-07 1:02 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509020518.32732.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxppc64-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox