Subject: Re: Makefile check for older binutils broken?

From: Marcelo Tosatti <[email-masked]>
Date: Wed, 26 Oct 2005 14:08:59 -0200

On Wed, Oct 26, 2005 at 09:59:20PM +0200, Andreas Schwab wrote:
> Marcelo Tosatti <[email-masked]> writes:
> 
> > Anyway, surrounding the verification command around an eval expression
> > does the trick correcting the situation. Is it any good? 
> 
> Not at all.  You have effectively disabled the check completely.
> 
> > diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
> > index 0432a25..cdd9250 100644
> > --- a/arch/ppc/Makefile
> > +++ b/arch/ppc/Makefile
> > @@ -126,7 +126,7 @@ checkbin:
> >  			false; \
> >  		fi ; \
> >  	fi
> > -	@if ! /bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1 ; then \
> > +	@if ! [[ "/bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1" ]] ; then \
> 
> A non-empty string is always true.

Doh - it seemed too easy. I'll go search for some clue (and buy a shell book).

I bet either Make or bash is screwing up.

Thanks