Subject: Re: [patch 38/43] Various powerpc 32bit ppc64 build fixes

From: Sven Luther <[email-masked]>
Date: Sat, 29 Oct 2005 08:27:24 +0200

On Sat, Oct 29, 2005 at 03:41:59PM +1000, Paul Mackerras wrote:
> Sven Luther writes:
> 
> > +ifeq ($(CONFIG_6xx),y)
> >  obj-$(CONFIG_PPC_PMAC)		+= pmac_pic.o pmac_setup.o pmac_time.o \
> >  					pmac_feature.o pmac_pci.o pmac_sleep.o \
> >  					pmac_low_i2c.o pmac_cache.o
> > +else
> > +obj-$(CONFIG_PPC_PMAC)		+= pmac_pic.o pmac_setup.o pmac_time.o \
> > +					pmac_feature.o pmac_pci.o pmac_sleep.o \
> > +					pmac_low_i2c.o
> > +endif
> 
> This is a bit gross.  How about:

Well, i sent to linuxppc-dev for comments too :)

> pmac-$(CONFIG_6xx)		:= pmac_cache.o
> obj-$(CONFIG_PPC_PMAC)		+= pmac_pic.o pmac_setup.o pmac_time.o \
> 					pmac_feature.o pmac_pci.o pmac_sleep.o \
> 					pmac_low_i2c.o $(pmac-y)
> 
> Care to send a revised patch?

Sure, i will do so early next week.

Friendly,

Sven Luther