Subject: Re: [PATCH] 8xx PCMCIA: support for MPC885ADS and MPC866ADS

From: Marcelo Tosatti <[email-masked]>
Date: Wed, 23 Nov 2005 10:53:26 -0200

Hi Vitaly,

On Fri, Nov 18, 2005 at 07:42:51PM +0300, Vitaly Bordug wrote:
> This adds adds PCMCIA supported for  both MPC885ADS and MPC866ADS.
> 
> This is established not together with FADS, because 885 does not have 
> io_block_mapping() for BCSR area.
> Also, some cleanups done both for 885ADS and MBX.
> 
> Signed-off-by: Vitaly Bordug <[email-masked]>

<snip>

> +	bcsr_io = ioremap(BCSR1, sizeof(unsigned long));

Shouldnt you handle ioremap() failure? Most 85xx code written
by Kumar also does not.