From: Marcelo Tosatti <marcelo.tosatti@cyclades•com>
To: Tom Rini <trini@kernel•crashing.org>
Cc: linux-ppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: INTERACTIVE_CONSOLE for misc-embedded.c and watchdog issue
Date: Fri, 2 Dec 2005 16:24:47 -0200 [thread overview]
Message-ID: <20051202182447.GA7579@dmt.cnet> (raw)
In-Reply-To: <20051128232738.GE7766@smtp.west.cox.net>
Hi Tom,
On Mon, Nov 28, 2005 at 04:27:38PM -0700, Tom Rini wrote:
> On Thu, Nov 17, 2005 at 01:17:30PM -0200, Marcelo Tosatti wrote:
>
> > The following patch against misc-embedded.c adds an INTERACTIVE_CONSOLE
> > #define to guard reading from console (causes unecessary delay in some
> > situations).
> >
> > Its an adaptation of misc.c's define, a difference being that platform
> > headers define "NO_INTERACTIVE_CONSOLE" if required.
> >
> > What do you think?
>
> Please put a comment above the #ifndef stating where the define should
> be. But I have a feeling that's going to be somewhere under
> arch/ppc/platforms/ or include/asm-ppc/ and I don't know if that's a
> good idea...
arch/ppc/platforms/ surely. You have a problem with that?
> I've got a vauge idea on how we can handle this a little bit more
> cleanly, in the merge tree.
How's that? Should I cancel the patch, then?
prev parent reply other threads:[~2005-12-02 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 15:17 INTERACTIVE_CONSOLE for misc-embedded.c and watchdog issue Marcelo Tosatti
2005-11-28 23:27 ` Tom Rini
2005-12-02 18:24 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051202182447.GA7579@dmt.cnet \
--to=marcelo.tosatti@cyclades$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=trini@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox