From: Andi Kleen <ak@suse•de>
To: Michael Tokarev <mjt@tls•msk.ru>
Cc: linux-mips@linux-mips•org, linux-ia64@vger•kernel.org,
Ian Molton <spyro@f2s•com>, David Howells <dhowells@redhat•com>,
linuxppc-dev@ozlabs•org, Greg Ungerer <gerg@uclinux•org>,
sparclinux@vger•kernel.org,
Miles Bader <uclinux-v850@lsi•nec.co.jp>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Hirokazu Takata <takata@linux-m32r•org>,
linuxsh-dev@lists•sourceforge.net,
Linus Torvalds <torvalds@osdl•org>,
Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
Richard Henderson <rth@twiddle•net>,
Akinobu Mita <mita@miraclelinux•com>,
Chris Zankel <chris@zankel•net>,
dev-etrax@axis•com, ultralinux@vger•kernel.org,
linux-m68k@lists•linux-m68k.org, linux-kernel@vger•kernel.org,
linuxsh-shmedia-dev@lists•sourceforge.net, linux390@de•ibm.com,
Russell King <rmk@arm•linux.org.uk>,
parisc-linux@parisc-linux•org
Subject: Re: [patch 14/44] generic hweight{64,32,16,8}()
Date: Wed, 1 Feb 2006 11:24:27 +0100 [thread overview]
Message-ID: <200602011124.29423.ak@suse.de> (raw)
In-Reply-To: <43E07EB2.4020409@tls.msk.ru>
On Wednesday 01 February 2006 10:26, Michael Tokarev wrote:
> Andi Kleen wrote:
> > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote:
> >
> >>+static inline unsigned int hweight32(unsigned int w)
> []
> > How large are these functions on x86? Maybe it would be better to not inline them,
> > but put it into some C file out of line.
>
> hweight8 47 bytes
> hweight16 76 bytes
> hweight32 97 bytes
> hweight64 56 bytes (NOT inlining hweight32)
> hweight64 197 bytes (inlining hweight32)
>
> Those are when compiled as separate non-inlined functions,
> with pushl %ebp and ret.
This would argue for moving them out of line.
-Andi
next prev parent reply other threads:[~2006-02-01 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060201090224.536581000@localhost.localdomain>
2006-02-01 9:02 ` [patch 06/44] generic __{, test_and_}{set, clear, change}_bit() and test_bit() Akinobu Mita
2006-02-01 9:02 ` [patch 10/44] generic fls64() Akinobu Mita
2006-02-01 9:02 ` [patch 12/44] generic sched_find_first_bit() Akinobu Mita
2006-02-03 3:58 ` [parisc-linux] " Grant Grundler
2006-02-01 9:02 ` [patch 14/44] generic hweight{64,32,16,8}() Akinobu Mita
2006-02-01 9:06 ` Andi Kleen
2006-02-01 9:26 ` Michael Tokarev
2006-02-01 10:24 ` Andi Kleen [this message]
2006-02-02 12:50 ` Akinobu Mita
2006-02-02 1:26 ` Gabriel Paubert
2006-02-06 11:52 ` Akinobu Mita
2006-02-03 8:31 ` Ulrich Eckhardt
2006-02-01 9:02 ` [patch 31/44] powerpc: use generic bitops Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602011124.29423.ak@suse.de \
--to=ak@suse$(echo .)de \
--cc=chris@zankel$(echo .)net \
--cc=dev-etrax@axis$(echo .)com \
--cc=dhowells@redhat$(echo .)com \
--cc=gerg@uclinux$(echo .)org \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux390@de$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxsh-dev@lists$(echo .)sourceforge.net \
--cc=linuxsh-shmedia-dev@lists$(echo .)sourceforge.net \
--cc=mita@miraclelinux$(echo .)com \
--cc=mjt@tls$(echo .)msk.ru \
--cc=parisc-linux@parisc-linux$(echo .)org \
--cc=rmk@arm$(echo .)linux.org.uk \
--cc=rth@twiddle$(echo .)net \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=spyro@f2s$(echo .)com \
--cc=takata@linux-m32r$(echo .)org \
--cc=torvalds@osdl$(echo .)org \
--cc=uclinux-v850@lsi$(echo .)nec.co.jp \
--cc=ultralinux@vger$(echo .)kernel.org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox