Subject: Re: [PATCH] missing refcounting of of_find_node_by_name users

From: Olaf Hering <[email-masked]>
Date: Tue, 7 Feb 2006 11:58:28 +0100

On Tue, Feb 07, Paul Mackeras wrote:

> This one isn't necessary, since np is NULL by the time we get out of
> the loop.  Same applies to the other places in this file that this
> patch affects.

Ok.

> > Index: linux-2.6.16-rc2-olh/arch/powerpc/platforms/powermac/pci.c
> > ===================================================================
> > --- linux-2.6.16-rc2-olh.orig/arch/powerpc/platforms/powermac/pci.c
> > +++ linux-2.6.16-rc2-olh/arch/powerpc/platforms/powermac/pci.c
> > @@ -695,6 +695,7 @@ static void __init fixup_nec_usb2(void)
> >  				nec->intrs[0].line);
> >  		}
> >  	}
> > +	of_put_node(nec);
> 
> Once again, nec is NULL by the time we get here.  And of_put_node
> doesn't exist. :(  Did you compile-test this?

Only with a pegasos only config, which doesnt cover these files.

-- 
short story of a lazy sysadmin:
 alias appserv=wotan