From: Olaf Hering <olh@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linuxppc64-dev@ozlabs•org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] change compat shmget size arg to signed
Date: Mon, 6 Mar 2006 20:38:17 +0100 [thread overview]
Message-ID: <20060306193817.GA3214@suse.de> (raw)
In-Reply-To: <20060224111242.08f14bd9.sfr@canb.auug.org.au>
On Fri, Feb 24, Stephen Rothwell wrote:
> On Fri, 24 Feb 2006 00:27:17 +0100 Olaf Hering <olh@suse•de> wrote:
> >
> > On Fri, Feb 24, Stephen Rothwell wrote:
> >
> > > Does the ltp test fail on a standard kernel(where SHMMAX is 0x2000000), or
> > > only on a SLES kernel (where SHMMAX is ULONG_MAX)?
> >
> > It fails with SLES9 and SLES10. SLES9 has 0x2000000 as default.
>
> So what was shm_ctlmax set to when the test was run.
>
> I am trying to figure out why this test:
>
> if (size < SHMMIN || size > shm_ctlmax)
> return -EINVAL;
>
> Doesn't return -EINVAL for size == 0xffffffff if shm_ctlmax is 0x2000000?
shm_ctlmax is a sysctrl, so it can have anything. The ltp test is
invalid. shmget02 dos not fail after:
echo $(( 0x2000000 )) > /proc/sys/kernel/shmmax
next prev parent reply other threads:[~2006-03-06 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 23:16 [PATCH] change compat shmget size arg to signed Stephen Rothwell
2006-02-23 23:27 ` Olaf Hering
2006-02-24 0:12 ` Stephen Rothwell
2006-03-06 19:38 ` Olaf Hering [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-02-20 18:39 Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060306193817.GA3214@suse.de \
--to=olh@suse$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxppc64-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox