From: Olof Johansson <olof@lixom•net>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: Milton Miller <miltonm@bga•com>,
linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>,
Olaf Hering <olh@suse•de>,
ellerman@au1•ibm.com
Subject: Re: [PATCH] kdump: Fix for machine checkstop on DMA fault
Date: Thu, 23 Mar 2006 00:19:04 -0600 [thread overview]
Message-ID: <20060323061904.GA22439@pb15.lixom.net> (raw)
In-Reply-To: <200603231706.35508.michael@ellerman.id.au>
On Thu, Mar 23, 2006 at 05:06:27PM +1100, Michael Ellerman wrote:
> On Thu, 23 Mar 2006 16:38, Olof Johansson wrote:
> > On Wed, Mar 22, 2006 at 08:30:26PM -0800, Haren Myneni wrote:
> > > Paul, If you are OK with this fix, please send it upstream.
> > >
> > > Thanks
> > > Haren
> > >
> > > - Some machines checkstop on dma protection fault for ongoing DMA left
> > > in the first kernel. Since, we do not shutdown devices before the kdump
> > > boot, let them continue DMA to old kernel space.
> >
> > How is this solved for regular kexec, doesn't the same problem exist
> > there?
>
> The idea for normal kexec is that the kernel should have shut everything down
> properly. It's a bug if there are still DMAs going on. Hopefully.
Thanks Michael.
In that case, I have to NACK the original patch.
Out of luck, it'll probably work in most cases, but there's always
the risk of a DMA still going on, the crash kernel remapping an entry,
and getting memory scribbled over.
The crash kernel needs to be even more careful, and instead read out
the entries that are mapped and reserve them. This would require a bit
more plumbing since there's no way to read an entry right now, but it'd
remove that hole.
-Olof
next prev parent reply other threads:[~2006-03-23 6:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 4:30 [PATCH] kdump: Fix for machine checkstop on DMA fault Haren Myneni
2006-03-23 5:38 ` Olof Johansson
2006-03-23 6:06 ` Michael Ellerman
2006-03-23 6:19 ` Olof Johansson [this message]
2006-03-23 20:12 ` Olof Johansson
2006-03-23 23:06 ` Haren Myneni
2006-03-23 23:11 ` Olof Johansson
2006-03-27 5:04 ` Michael Ellerman
2006-03-27 14:06 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323061904.GA22439@pb15.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=ellerman@au1$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
--cc=miltonm@bga$(echo .)com \
--cc=olh@suse$(echo .)de \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox