From: Olof Johansson <olof@lixom•net>
To: Olof Johansson <olof@lixom•net>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH 2/2] Base pSeries PCIe support
Date: Fri, 31 Mar 2006 17:08:28 -0600 [thread overview]
Message-ID: <20060331230827.GD952@pb15.lixom.net> (raw)
In-Reply-To: <20060331224858.GC952@pb15.lixom.net>
On Fri, Mar 31, 2006 at 04:48:58PM -0600, Olof Johansson wrote:
> > + dn->intrs = prom_alloc(dn->n_intrs * sizeof(*(dn->intrs)), mem_start);
> > + if (!dn->intrs) {
> > + printk(KERN_EMERG "finish_msi_node: can't allocate space\n");
> > + return;
> > + }
> > +
> > + if (measure_only)
> > + return;
>
> You probably want to return from measure_only _before_ you allocate and
> populate intrs...
Nevermind, this is correct as-is.
-Olof
next prev parent reply other threads:[~2006-03-31 23:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 22:02 [PATCH 0/2] Base pSeries PCIe support Jake Moilanen
2006-03-31 22:05 ` [PATCH 1/2] " Jake Moilanen
2006-03-31 22:15 ` Dave Hansen
2006-03-31 22:18 ` Jake Moilanen
2006-04-12 4:06 ` Christoph Hellwig
2006-03-31 22:13 ` [PATCH 2/2] " Jake Moilanen
2006-03-31 22:48 ` Olof Johansson
2006-03-31 23:08 ` Olof Johansson [this message]
2006-04-01 8:36 ` Paul Mackerras
2006-04-01 22:57 ` Jake Moilanen
2006-04-10 15:39 ` Jake Moilanen
2006-04-11 21:31 ` Benjamin Herrenschmidt
2006-04-01 8:38 ` Paul Mackerras
2006-04-12 4:05 ` Christoph Hellwig
2006-03-31 22:28 ` [PATCH 0/2] " Arnd Bergmann
2006-03-31 22:35 ` Jake Moilanen
2006-03-31 22:39 ` Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060331230827.GD952@pb15.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox