From: Arnd Bergmann <arnd.bergmann@de•ibm.com>
To: cbe-oss-dev@ozlabs•org
Cc: linuxppc-dev@ozlabs•org, Mark Nutter <mnutter@us•ibm.com>
Subject: Re: [Cbe-oss-dev] [PATCH 4/5] powerpc: export symbols for page size selection
Date: Fri, 7 Apr 2006 18:49:34 +0200 [thread overview]
Message-ID: <200604071849.35391.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <20060407162026.GK952@pb15.lixom.net>
On Friday 07 April 2006 18:20, Olof Johansson wrote:
> On Fri, Apr 07, 2006 at 06:03:01PM +0200, Arnd Bergmann wrote:
> > On Friday 07 April 2006 17:42, Olof Johansson wrote:
> > > Yeah, what's the need for that, really? It needs to know so much of
> > > kernel internals that it's getting silly to allow it to be a module.
> >
> > How about if I do a patch that always includes the base but not
> > the actual file system?
>
> Sounds like a decent tradeoff.
>
Unfortunately, this one doesn't get rid of the need to have the
exports, since the context switch code also needs mmu_psize_defs
and the associated objects. I think I have to come up with
a different change for that, but I don't mind putting the base
stuff into the kernel in the first place.
Mark has some changes to the file layout pending that will
impact this as well. I first need to see how that works out
together.
The patch to make the base non-modular is trivial, so we might
as well apply it now.
Arnd <><
Index: linus-2.6/arch/powerpc/platforms/cell/Makefile
===================================================================
--- linus-2.6.orig/arch/powerpc/platforms/cell/Makefile
+++ linus-2.6/arch/powerpc/platforms/cell/Makefile
@@ -2,15 +2,13 @@ obj-y += interrupt.o iommu.o setup.o s
obj-y += pervasive.o
obj-$(CONFIG_SMP) += smp.o
-obj-$(CONFIG_SPU_FS) += spu-base.o spufs/
-
-spu-base-y += spu_base.o spu_priv1.o
+obj-$(CONFIG_SPU_FS) += spufs/
# needed only when building loadable spufs.ko
spufs-modular-$(CONFIG_SPU_FS) += spu_syscalls.o
obj-y += $(spufs-modular-m)
# always needed in kernel
-spufs-builtin-$(CONFIG_SPU_FS) += spu_callbacks.o
+spufs-builtin-$(CONFIG_SPU_FS) += spu_callbacks.o spu_base.o spu_priv1.o
obj-y += $(spufs-builtin-y) $(spufs-builtin-m)
next prev parent reply other threads:[~2006-04-07 16:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 15:01 [PATCH 0/5] cell: recent bug fixes arnd
2006-04-06 22:00 ` [PATCH 1/5] spufs: Disable local interrupts for SPE hash_page calls arnd
2006-04-06 22:00 ` [PATCH 2/5] powerpc: fix 64k pages on non-hypervisor arnd
2006-04-06 22:00 ` [PATCH 3/5] spufs: set up correct SLB entries for 64k pages arnd
2006-04-06 22:00 ` [PATCH 4/5] powerpc: export symbols for page size selection arnd
2006-04-07 15:28 ` Christoph Hellwig
2006-04-07 15:42 ` Olof Johansson
2006-04-07 15:54 ` [Cbe-oss-dev] " Geoff Levand
2006-04-07 16:03 ` Arnd Bergmann
2006-04-07 16:20 ` Olof Johansson
2006-04-07 16:49 ` Arnd Bergmann [this message]
2006-04-11 1:21 ` Benjamin Herrenschmidt
2006-04-06 22:00 ` [PATCH 5/5] cell: enable CPU_FTR_CI_LARGE_PAGE arnd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604071849.35391.arnd.bergmann@de.ibm.com \
--to=arnd.bergmann@de$(echo .)ibm.com \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mnutter@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox