From: Christoph Hellwig <hch@infradead•org>
To: J?rn Engel <joern@wohnheim•fh-wedel.de>
Cc: linux-kernel@vger•kernel.org, openib-general@openib•org,
linuxppc-dev@ozlabs•org, Christoph Raisch <RAISCH@de•ibm.com>,
Hoang-Nam Nguyen <HNGUYEN@de•ibm.com>,
Marcus Eder <MEDER@de•ibm.com>
Subject: Re: [PATCH 03/16] ehca: structure definitions
Date: Thu, 27 Apr 2006 12:59:15 +0100 [thread overview]
Message-ID: <20060427115915.GA15520@infradead.org> (raw)
In-Reply-To: <20060427115749.GD32127@wohnheim.fh-wedel.de>
On Thu, Apr 27, 2006 at 01:57:49PM +0200, J?rn Engel wrote:
> On Thu, 27 April 2006 12:48:13 +0200, Heiko J Schick wrote:
> > +
> > +#ifdef CONFIG_PPC64
> > +#include "ehca_classes_pSeries.h"
> > +#endif
>
> Is the #ifdef necessary? Such conditions around header includes often
> indicate problems with the included header. If that is the case here,
> you should fix the header in question in a seperate patch.
The real question is what is that ifdef for at all? The code subitted
isn't built on anything but ppc64.
prev parent reply other threads:[~2006-04-27 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 10:48 [PATCH 03/16] ehca: structure definitions Heiko J Schick
2006-04-27 11:57 ` Jörn Engel
2006-04-27 11:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060427115915.GA15520@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=HNGUYEN@de$(echo .)ibm.com \
--cc=MEDER@de$(echo .)ibm.com \
--cc=RAISCH@de$(echo .)ibm.com \
--cc=joern@wohnheim$(echo .)fh-wedel.de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=openib-general@openib$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox