public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling•org>
To: jschopp <jschopp@austin•ibm.com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] powerpc: whitespace cleanup in reg.h
Date: Tue, 09 May 2006 14:01:05 -0500	[thread overview]
Message-ID: <20060509190145.D360567A79@ozlabs.org> (raw)
In-Reply-To: <4460E0BC.4050908@austin.ibm.com>

> But then you seem to be trying to do indenting with 3 spaces instead of tabs.

I disagree.  These used to be #define<tab><space><space>.  I just
changed them to #define<space><space><space>.

> And your values don't line up, and your comments don't line up.

Try applying the patch and looking at reg.h.  It looks much different
there than in the patch.  

> I'm just saying, either fix the formatting right or don't fix it at
> all.  Moving it from one ugly to another ugly is not worth the trouble.

With 8 character tabs, I've not changed to look at all.  

Mikey

  parent reply	other threads:[~2006-05-09 19:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-09 16:33 [PATCH] powerpc: whitespace cleanup in reg.h Michael Neuling
2006-05-09 18:34 ` jschopp
2006-05-09 18:56   ` Hollis Blanchard
2006-05-09 19:01   ` Michael Neuling [this message]
2006-05-10  3:14   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060509190145.D360567A79@ozlabs.org \
    --to=mikey@neuling$(echo .)org \
    --cc=jschopp@austin$(echo .)ibm.com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox