From: Andrew Morton <akpm@osdl•org>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: PowerMac: force only suspend-to-disk to be valid
Date: Thu, 25 May 2006 07:05:58 -0700 [thread overview]
Message-ID: <20060525070558.2b7e24cd.akpm@osdl.org> (raw)
In-Reply-To: <1148551527.11759.10.camel@johannes.berg>
Johannes Berg <johannes@sipsolutions•net> wrote:
>
> On Tue, 2006-05-02 at 11:31 +0200, Johannes Berg wrote:
> > This patch adds the .valid callback to pm_ops on PowerMac so that only the
> > suspend to disk state can be entered. Note that just returning 0 would
> > suffice since the upper layers don't pass PM_SUSPEND_DISK down, but I think
> > they ought to be passing it down since they do really need support (or
> > am I mistaken again?) so we handle it there regardless.
>
> No one ever seemed to care about this patch,
I don't recall having seen it before.
> can we queue it up for
> 2.6.18? I suppose it's too late now for 2.6.17 even if it fixes the
> long-standing but that on ppc, /sys/power/state kills the machine.
>
> [quoted patch for reference]
>
> > --- wireless-dev.orig/arch/powerpc/platforms/powermac/setup.c 2006-05-02 10:57:32.101509438 +0200
> > +++ wireless-dev/arch/powerpc/platforms/powermac/setup.c 2006-05-02 10:58:44.491509438 +0200
> > @@ -463,11 +463,23 @@ static int pmac_pm_finish(suspend_state_
> > return 0;
> > }
> >
> > +static int pmac_pm_valid(suspend_state_t state)
> > +{
> > + switch (state) {
> > + case PM_SUSPEND_DISK:
> > + return 1;
> > + /* can't do any other states via generic mechanism yet */
> > + default:
> > + return 0;
> > + }
> > +}
> > +
> > static struct pm_ops pmac_pm_ops = {
> > .pm_disk_mode = PM_DISK_SHUTDOWN,
> > .prepare = pmac_pm_prepare,
> > .enter = pmac_pm_enter,
> > .finish = pmac_pm_finish,
> > + .valid = pmac_pm_valid,
> > };
> >
> > #endif /* CONFIG_SOFTWARE_SUSPEND */
>
It looks like a 2.6.17 patch to me. If someone wants to send it over with
changelog, signed-off-by, etc I can take care of it.
next prev parent reply other threads:[~2006-05-25 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-02 9:31 PowerMac: force only suspend-to-disk to be valid Johannes Berg
2006-05-25 10:05 ` Johannes Berg
2006-05-25 14:05 ` Andrew Morton [this message]
2006-05-25 14:10 ` Andrew Morton
2006-05-25 14:13 ` Johannes Berg
2006-05-25 23:11 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060525070558.2b7e24cd.akpm@osdl.org \
--to=akpm@osdl$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox