From: Andrew Morton <akpm@osdl•org>
To: Jeremy Fitzhardinge <jeremy@goop•org>
Cc: drfickle@us•ibm.com, linux-kernel@vger•kernel.org,
mbligh@mbligh•org, mbligh@google•com, linuxppc64-dev@ozlabs•org
Subject: Re: 2.6.17-mm2
Date: Wed, 28 Jun 2006 12:49:06 -0700 [thread overview]
Message-ID: <20060628124906.b289e80b.akpm@osdl.org> (raw)
In-Reply-To: <44A2D6DA.1050607@goop.org>
On Wed, 28 Jun 2006 12:22:02 -0700
Jeremy Fitzhardinge <jeremy@goop•org> wrote:
> Andrew Morton wrote:
> > Found a way to reproduce it - do `cat /proc/slabinfo > /dev/null' in a
> > tight loop. With that happening, a little two-way wasn't able to make
> > it through `dbench 4' without soiling the upholstery. Then bisection-searching.
> >
> It's surprising it was so subtle. I'd been running with that code for a
> month or so without a peep of problem...
>
It'll only bite if someone does snprintf() into a too-short buffer. That's
rare (it's usually a bug). But it looks like the seq_file() code does it
when someone is trying to generate more than PAGE_SIZE's worth of data.
Like /proc/slabinfo.
next prev parent reply other threads:[~2006-06-28 19:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <449D5D36.3040102@google.com>
[not found] ` <449FF3A2.8010907@mbligh.org>
2006-06-27 15:37 ` 2.6.17-mm2 Martin J. Bligh
2006-06-28 10:42 ` 2.6.17-mm2 Andrew Morton
2006-06-28 10:47 ` 2.6.17-mm2 Andrew Morton
2006-06-28 14:43 ` 2.6.17-mm2 Martin J. Bligh
2006-06-28 15:06 ` 2.6.17-mm2 Andy Whitcroft
2006-06-28 19:11 ` 2.6.17-mm2 Andrew Morton
2006-06-28 19:22 ` 2.6.17-mm2 Jeremy Fitzhardinge
2006-06-28 19:49 ` Andrew Morton [this message]
2006-06-28 19:36 ` 2.6.17-mm2 Martin Bligh
2006-06-29 0:17 ` 2.6.17-mm2 Martin J. Bligh
2006-06-28 15:43 ` 2.6.17-mm2 Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628124906.b289e80b.akpm@osdl.org \
--to=akpm@osdl$(echo .)org \
--cc=drfickle@us$(echo .)ibm.com \
--cc=jeremy@goop$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc64-dev@ozlabs$(echo .)org \
--cc=mbligh@google$(echo .)com \
--cc=mbligh@mbligh$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox