From: Aristeu Sergio Rozanski Filho <aris@valeta•org>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powermac: defer work in backlight key press
Date: Tue, 4 Jul 2006 08:03:54 -0300 [thread overview]
Message-ID: <20060704110354.GA30435@cathedrallabs.org> (raw)
In-Reply-To: <1152000419.20701.48.camel@localhost>
> > + /* we can receive multiple interrupts here, but the scheduled work
> > + * will run only once, with the last value */
> > + pmac_backlight_key_queued = direction;
>
> Shouldn't you be doing something like using the whole
> pmac_backlight_key_queued in the workqueue, then setting it to 0 there
> and using += here? That way all keypresses will be adhered to.
today pmac_backlight_key() is called either with 0 (to reduce backlight
level) or 1 (to increase). I found that actually happening two
keystrokes between interrupt being serviced and actually running that
work queue would be so damn small that the extra code wouldn't be worth.
but if you think it's worth for, I can fix it, no problem.
--
Aristeu
next prev parent reply other threads:[~2006-07-04 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 1:39 [PATCH] powermac: defer work in backlight key press Aristeu Sergio Rozanski Filho
2006-07-04 8:06 ` Johannes Berg
2006-07-04 11:03 ` Aristeu Sergio Rozanski Filho [this message]
2006-07-04 11:16 ` Johannes Berg
2006-07-08 14:35 ` Michael Hanselmann
2006-07-08 15:58 ` [PATCH] powermac: defer work in backlight key press (and export fixes) Michael Hanselmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060704110354.GA30435@cathedrallabs.org \
--to=aris@valeta$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox