From: Arnd Bergmann <arnd@arndb•de>
To: Mike Kravetz <kravetz@us•ibm.com>
Cc: Bryan Rosenburg <rosnbrg@us•ibm.com>,
linuxppc-dev@ozlabs•org, Nathan Lynch <ntl@pobox•com>,
Christopher Yeoh <cyeoh@samba•org>
Subject: Re: [PATCH 0/3] powerpc: Instrument Hypervisor Calls
Date: Mon, 10 Jul 2006 22:49:49 +0200 [thread overview]
Message-ID: <200607102249.50630.arnd@arndb.de> (raw)
In-Reply-To: <20060710203510.GA30793@w-mikek2.ibm.com>
On Monday 10 July 2006 22:35, Mike Kravetz wrote:
> On Thu, Jun 22, 2006 at 03:56:09PM -0700, Mike Kravetz wrote:
> > This version addresses all comments received except Arnd's issue
> > with an #ifdef for each function in the assembly file.
>
> I was thinking of changing the names of all the assembly routines from
> plpar_hcall_*() to plpar_hcall_*_asm(). The instrumented version of the
> routines would be named plpar_hcall_*_inst(). Then, the header file
> would contain definitions such as:
>
> #ifdef CONFIG_HCALL_STATS
> #define plpar_hcall_*() plpar_hcall_*_inst()
> .
> #else
> #define plpar_hcall_*() plpar_hcall_*_asm()
> .
> #endif
>
> Is that any better than all the individual #ifdefs in the .S file? Is it
> still too ugly?
>
I guess it's better to have the #ifdef in the header file, but then
again, you could just as well save some source lines doing
#ifndef CONFIG_HCALL_STATS
#define plpar_hcalldef(x) plpar_call_ ## x ## _asm
#else
#define plpar_hcalldef(x) plpar_call_ ## x ## _inst
#endif
#define plpar_call_foo plpar_hcalldef(foo)
Arnd <><
next prev parent reply other threads:[~2006-07-10 20:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 22:56 [PATCH 0/3] powerpc: Instrument Hypervisor Calls Mike Kravetz
2006-06-22 22:57 ` [PATCH 1/3] powerpc: Instrument Hypervisor Calls: merge headers Mike Kravetz
2006-06-22 22:58 ` [PATCH 2/3] powerpc: Instrument Hypervisor Calls: add wrappers Mike Kravetz
2006-06-22 23:00 ` [PATCH 3/3] powerpc: Instrument Hypervisor Calls: add debugfs files Mike Kravetz
2006-06-23 0:28 ` [PATCH 0/3] powerpc: Instrument Hypervisor Calls Segher Boessenkool
2006-07-10 20:35 ` Mike Kravetz
2006-07-10 20:49 ` Arnd Bergmann [this message]
2006-07-12 18:05 ` Mike Kravetz
-- strict thread matches above, loose matches on Subject: below --
2006-07-21 6:38 Mike Kravetz
2006-07-18 20:47 Mike Kravetz
2006-07-18 21:00 ` Paul Mackerras
2006-07-19 3:36 ` Mike Kravetz
2006-07-19 22:11 ` Mike Kravetz
2006-07-18 21:29 ` Mike Kravetz
2006-07-18 22:38 ` Olof Johansson
2006-07-14 23:37 Mike Kravetz
2006-07-15 0:00 ` Arnd Bergmann
2006-07-15 0:06 ` Mike Kravetz
2006-07-15 15:30 ` Anton Blanchard
2006-07-15 16:42 ` Arnd Bergmann
2006-07-15 22:07 ` Anton Blanchard
2006-07-16 23:02 ` Luke Browning
2006-07-17 2:02 ` Luke Browning
2006-07-16 3:53 ` Olof Johansson
2006-07-16 22:53 ` Luke Browning
2006-07-16 23:09 ` Olof Johansson
2006-06-14 3:47 Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607102249.50630.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=cyeoh@samba$(echo .)org \
--cc=kravetz@us$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=ntl@pobox$(echo .)com \
--cc=rosnbrg@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox