From: Johannes Berg <johannes@sipsolutions•net>
To: linuxppc-dev@ozlabs•org
Cc: alsa-devel@alsa-project•org
Subject: [PATCH 3/5] make snd-powermac load even when it cant bind the device
Date: Tue, 18 Jul 2006 19:28:44 +0200 [thread overview]
Message-ID: <20060718173017.459954000@sipsolutions.net> (raw)
In-Reply-To: 20060718172841.046446000@sipsolutions.net
This patch makes snd-powermac load when it can't bind the device right
away. That's the expected behaviour for hotplugging, but fixes an
important problem I was seeing with doing a modprobe snd-powermac with
a version that refuses loading on machines with layout-id: snd-powermac
would create a bunch of uevents and then refuse to load, the uevents
causing udev to reload it again, ad eternum.
Signed-off-by: Johannes Berg <johannes@sipsolutions•net>
--- linux-2.6-fetch.orig/sound/ppc/powermac.c 2006-07-18 18:16:53.633476868 +0200
+++ linux-2.6-fetch/sound/ppc/powermac.c 2006-07-18 18:40:39.243476868 +0200
@@ -181,21 +181,14 @@ static int __init alsa_card_pmac_init(vo
if ((err = platform_driver_register(&snd_pmac_driver)) < 0)
return err;
device = platform_device_register_simple(SND_PMAC_DRIVER, -1, NULL, 0);
- if (!IS_ERR(device)) {
- if (platform_get_drvdata(device))
- return 0;
- platform_device_unregister(device);
- err = -ENODEV;
- } else
- err = PTR_ERR(device);
- platform_driver_unregister(&snd_pmac_driver);
- return err;
+ return 0;
}
static void __exit alsa_card_pmac_exit(void)
{
- platform_device_unregister(device);
+ if (!IS_ERR(device))
+ platform_device_unregister(device);
platform_driver_unregister(&snd_pmac_driver);
}
--
next prev parent reply other threads:[~2006-07-18 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-18 17:28 [PATCH 0/5] powerpc sound, some more patches Johannes Berg
2006-07-18 17:28 ` [PATCH 1/5] aoa: feature gpio layer: fix IRQ access Johannes Berg
2006-07-18 18:45 ` Benjamin Herrenschmidt
2006-07-18 17:28 ` [PATCH 2/5] aoa: fix toonie codec Johannes Berg
2006-07-18 17:28 ` Johannes Berg [this message]
2006-07-18 17:28 ` [PATCH 4/5] aoa: platform function gpio: ignore errors from functions that dont exist Johannes Berg
2006-07-18 17:28 ` [PATCH 5/5] add MAINTAINERS entry for snd-aoa Johannes Berg
2006-07-25 14:17 ` [Alsa-devel] [PATCH 0/5] powerpc sound, some more patches Takashi Iwai
2006-07-25 15:13 ` Johannes Berg
2006-07-25 15:21 ` Takashi Iwai
2006-08-05 16:09 ` Johannes Berg
2006-07-25 21:52 ` Benjamin Herrenschmidt
2006-07-26 17:19 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060718173017.459954000@sipsolutions.net \
--to=johannes@sipsolutions$(echo .)net \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox