From: Horms <horms@verge•net.au>
To: Chuck Ebbert <76306.1226@compuserve•com>
Cc: Andrew Morton <akpm@osdl•org>, Chris Zankel <chris@zankel•net>,
Tony Luck <tony.luck@intel•com>,
linux-ia64 <linux-ia64@vger•kernel.org>,
discuss@x86-64•org, Andi Kleen <ak@suse•de>,
linux-kernel <linux-kernel@vger•kernel.org>,
linuxppc-dev <linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>,
Anton Blanchard <anton@samba•org>,
Russell King <rmk@arm•linux.org.uk>
Subject: Re: [PATCH] panic_on_oops: remove ssleep()
Date: Tue, 18 Jul 2006 15:15:00 -0400 [thread overview]
Message-ID: <20060718191456.GF20141@verge.net.au> (raw)
In-Reply-To: <200607172126_MC3-1-C544-E35A@compuserve.com>
On Mon, Jul 17, 2006 at 09:22:17PM -0400, Chuck Ebbert wrote:
> In-Reply-To: <31687.FP.7244@verge•net.au>
>
> On Mon, 17 Jul 2006 12:17:20 -0400, Horms wrote:
>
> > This patch is part of an effort to unify the panic_on_oops behaviour
> > across all architectures that implement it.
> >
> > It was pointed out to me by Andi Kleen that if an oops has occured
> > in interrupt context, then calling sleep() in the oops path will only cause
> > a panic, and that it would be really better for it not to be in the path at
> > all.
>
> i386 already checks in_interrupt() and panics immediately:
Very good point. I guess that needs to be moved to after
panic_on_oops() if the change that Andi suggests works out.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
next prev parent reply other threads:[~2006-07-18 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-18 1:22 [PATCH] panic_on_oops: remove ssleep() Chuck Ebbert
2006-07-18 19:15 ` Horms [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-17 16:17 Horms
2006-07-17 22:27 ` Andi Kleen
2006-07-17 23:10 ` Horms
2006-07-18 0:23 ` Andrew Morton
2006-07-18 19:13 ` Horms
2006-07-20 16:03 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060718191456.GF20141@verge.net.au \
--to=horms@verge$(echo .)net.au \
--cc=76306.1226@compuserve$(echo .)com \
--cc=ak@suse$(echo .)de \
--cc=akpm@osdl$(echo .)org \
--cc=anton@samba$(echo .)org \
--cc=chris@zankel$(echo .)net \
--cc=discuss@x86-64$(echo .)org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=rmk@arm$(echo .)linux.org.uk \
--cc=tony.luck@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox