From: Jean Delvare <khali@linux-fr•org>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Munaut <tnt@246tNt•com>, Sylvain
Subject: Re: [RFC] I2C-MPC: Fix up error handling
Date: Mon, 31 Jul 2006 08:57:24 +0200 [thread overview]
Message-ID: <20060731085724.00447d21.khali@linux-fr.org> (raw)
In-Reply-To: <A18434C2-2C6F-4052-B3F3-AE9D2CE38BE3@kernel.crashing.org>
> > Quoting myself:
> > > Could anyone please comment on this i2c-mpc patch, and give it some
> > > testing on different systems? I'm fine with the error propagation
> > > fixes, but less fine with the random resets being added, and rather
> > > unhappy with the "retry once more just in case" thing, which I think,
> > > if really needed, should instead be implemented using the standard
> > > i2c_adapter.retries mechanism.
> >
> > Can anyone please comment on this patch? Andrew Morton keeps
> > forwarding it to me, but I don't think I can accept it as is (see
> > my complaints above.)
>
> If I find some time, let me split out the error propagation so we can
> get that fix up stream. The other code was to handle a buggy device
> that was connected in one system I was working on.
Sounds like a good plan, thanks.
--
Jean Delvare
prev parent reply other threads:[~2006-07-31 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-09 7:54 [RFC] I2C-MPC: Fix up error handling Jean Delvare
2006-07-30 11:14 ` Jean Delvare
2006-07-30 16:23 ` Kumar Gala
2006-07-31 6:57 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731085724.00447d21.khali@linux-fr.org \
--to=khali@linux-fr$(echo .)org \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tnt@246tNt$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox