Subject: Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

From: Stephen Hemminger <[email-masked]>
Date: Fri, 18 Aug 2006 10:45:47 -0700

On Fri, 18 Aug 2006 17:41:26 +0200
Thomas Klein <[email-masked]> wrote:

> Hi Alexey,
> 
> first of all thanks a lot for the extensive review.
> 
> 
> Alexey Dobriyan wrote:
> >> +	u64 hret = H_HARDWARE;
> > 
> > Useless assignment here and everywhere.
> > 
> 
> Initializing returncodes to errorstate is a cheap way to prevent
> accidentally returning (uninitalized) success returncodes which
> can lead to catastrophic misbehaviour.

That is old thinking. Current compilers do live/dead analysis
and tell you about this at compile time which is better than relying
on default behavior at runtime.