From: linas@austin•ibm.com (Linas Vepstas)
To: Jeff Garzik <jgarzik@pobox•com>
Cc: akpm@osdl•org, Arnd Bergmann <arnd@arndb•de>,
netdev@vger•kernel.org, James K Lewis <jklewis@us•ibm.com>,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
ens Osterkamp <Jens.Osterkamp@de•ibm.com>
Subject: [PATCH 3/6]: powerpc/cell spidernet stop error printing patch.
Date: Fri, 18 Aug 2006 17:23:11 -0500 [thread overview]
Message-ID: <20060818222311.GJ26889@austin.ibm.com> (raw)
In-Reply-To: <20060818220700.GG26889@austin.ibm.com>
Turn off mis-interpretation of the queue-empty interrupt
status bit as an error. This bit is set as a part of
the previous low-watermark patch.
Signed-off-by: Linas Vepstas <linas@austin•ibm.com>
Signed-off-by: James K Lewis <jklewis@us•ibm.com>
Cc: Utz Bacher <utz.bacher@de•ibm.com>
Cc: Jens Osterkamp <Jens.Osterkamp@de•ibm.com>
Cc: Arnd Bergmann <arnd@arndb•de>
----
drivers/net/spider_net.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
Index: linux-2.6.18-rc3-mm2/drivers/net/spider_net.c
===================================================================
--- linux-2.6.18-rc3-mm2.orig/drivers/net/spider_net.c 2006-08-11 11:23:24.000000000 -0500
+++ linux-2.6.18-rc3-mm2/drivers/net/spider_net.c 2006-08-11 11:34:16.000000000 -0500
@@ -1275,12 +1275,15 @@ spider_net_handle_error_irq(struct spide
case SPIDER_NET_PHYINT:
case SPIDER_NET_GMAC2INT:
case SPIDER_NET_GMAC1INT:
- case SPIDER_NET_GIPSINT:
case SPIDER_NET_GFIFOINT:
case SPIDER_NET_DMACINT:
case SPIDER_NET_GSYSINT:
break; */
+ case SPIDER_NET_GIPSINT:
+ show_error = 0;
+ break;
+
case SPIDER_NET_GPWOPCMPINT:
/* PHY write operation completed */
show_error = 0;
@@ -1339,9 +1342,10 @@ spider_net_handle_error_irq(struct spide
case SPIDER_NET_GDTDCEINT:
/* chain end. If a descriptor should be sent, kick off
* tx dma
- if (card->tx_chain.tail == card->tx_chain.head)
+ if (card->tx_chain.tail != card->tx_chain.head)
spider_net_kick_tx_dma(card);
- show_error = 0; */
+ */
+ show_error = 0;
break;
/* case SPIDER_NET_G1TMCNTINT: not used. print a message */
@@ -1455,8 +1459,9 @@ spider_net_handle_error_irq(struct spide
}
if ((show_error) && (netif_msg_intr(card)))
- pr_err("Got error interrupt, GHIINT0STS = 0x%08x, "
+ pr_err("Got error interrupt on %s, GHIINT0STS = 0x%08x, "
"GHIINT1STS = 0x%08x, GHIINT2STS = 0x%08x\n",
+ card->netdev->name,
status_reg, error_reg1, error_reg2);
/* clear interrupt sources */
next prev parent reply other threads:[~2006-08-18 22:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 22:07 [PATCH 0/6]: powerpc/cell spidernet ethernet driver update Linas Vepstas
2006-08-18 22:20 ` [PATCH 1/6]: powerpc/cell spidernet burst alignment patch Linas Vepstas
2006-08-18 22:51 ` Arnd Bergmann
2006-08-18 22:21 ` [PATCH 2/6]: powerpc/cell spidernet low watermark patch Linas Vepstas
2006-08-18 23:09 ` Arnd Bergmann
2006-08-20 6:31 ` Benjamin Herrenschmidt
2006-08-20 10:03 ` Arnd Bergmann
2006-08-23 21:36 ` Linas Vepstas
2006-08-23 22:03 ` David Miller
2006-08-18 22:23 ` Linas Vepstas [this message]
2006-08-18 22:25 ` [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info Linas Vepstas
2006-08-18 22:56 ` Arnd Bergmann
2006-08-18 22:26 ` [PATCH 5/6]: powerpc/cell spidernet bottom half Linas Vepstas
2006-08-18 23:03 ` Arnd Bergmann
2006-08-19 0:56 ` [RFC] HOWTO use NAPI to reduce TX interrupts Arnd Bergmann
2006-08-20 1:31 ` Stephen Hemminger
2006-08-19 11:25 ` Arnd Bergmann
2006-08-20 17:48 ` [RFC v2] " Arnd Bergmann
2006-08-21 20:40 ` NAPI documentation Stephen Hemminger
2006-08-21 22:05 ` David Miller
2006-08-21 22:09 ` Stephen Hemminger
2006-08-21 22:17 ` David Miller
2006-08-21 23:52 ` [RFC] HOWTO use NAPI to reduce TX interrupts Linas Vepstas
2006-08-21 23:56 ` David Miller
2006-08-22 0:29 ` Roland Dreier
2006-08-22 0:32 ` David Miller
2006-08-23 1:29 ` Shirley Ma
2006-08-23 21:52 ` [PATCH 5/6]: powerpc/cell spidernet bottom half Linas Vepstas
2006-08-18 22:29 ` [PATCH 6/6]: powerpc/cell spidernet refine locking Linas Vepstas
-- strict thread matches above, loose matches on Subject: below --
2006-09-29 23:05 [PATCH 0/6]: powerpc/cell spidernet ethernet patches Linas Vepstas
2006-09-29 23:19 ` [PATCH 3/6]: powerpc/cell spidernet stop error printing patch Linas Vepstas
2006-09-30 10:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060818222311.GJ26889@austin.ibm.com \
--to=linas@austin$(echo .)ibm.com \
--cc=Jens.Osterkamp@de$(echo .)ibm.com \
--cc=akpm@osdl$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=jgarzik@pobox$(echo .)com \
--cc=jklewis@us$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox