From: Arnd Bergmann <arnd@arndb•de>
To: cbe-oss-dev@ozlabs•org
Cc: Olof Johansson <olof@lixom•net>, linuxppc-dev@ozlabs•org
Subject: Re: [Cbe-oss-dev] [PATCH] powerpc: allow PHBs anywhere in the device tree
Date: Tue, 12 Sep 2006 23:16:21 +0200 [thread overview]
Message-ID: <200609122316.21820.arnd@arndb.de> (raw)
In-Reply-To: <20060912145438.30b6bf80@localhost.localdomain>
On Tuesday 12 September 2006 21:54, Olof Johansson wrote:
> !strcasecmp(...) instead?
I do that normally for functions that return either a truth value
or a pointer to an object that may be NULL, whereas strcasecmp
returns a numerical value that I'm checking for a specific result.
This is also consistant with how it is used elsewhere in the file.
> Do they ever exist in non-lowercase versions? Old code just did
> strcmp().
I took that from device_is_compatible(), which also does
strncasecmp, so I assumed that was done for a reason.
> > + *=A0=A0=A0@from:=A0=A0The node to start searching from or NULL, the n=
ode
> > + *=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0you pass will not be searched, only=
the next one
> > + *=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0will; typically, you pass what the =
previous call
> > + *=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0returned. of_node_put() will be cal=
led on it
>=20
> Convention seems to be to call this "prev", not "from"?
ok
Arnd <><
next prev parent reply other threads:[~2006-09-12 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 17:52 [PATCH] powerpc: allow PHBs anywhere in the device tree Arnd Bergmann
2006-09-12 19:54 ` Olof Johansson
2006-09-12 21:16 ` Arnd Bergmann [this message]
2006-09-12 21:44 ` [Cbe-oss-dev] " Olof Johansson
2006-09-12 22:20 ` Paul Mackerras
2006-09-12 22:39 ` [Cbe-oss-dev] " Arnd Bergmann
2006-09-13 1:46 ` Benjamin Herrenschmidt
2006-09-13 0:23 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609122316.21820.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox