Subject: Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.

From: Arnd Bergmann <[email-masked]>
Date: Sat, 30 Sep 2006 12:33:45 +0200

Am Saturday 30 September 2006 01:21 schrieb Linas Vepstas:
> This patch adds version information as reported by
> ethtool -i to the Spidernet driver.
>
> From: James K Lewis <[email-masked]>
> Signed-off-by: James K Lewis <[email-masked]>
> Signed-off-by: Linas Vepstas <[email-masked]>
> Cc: Arnd Bergmann <[email-masked]>

Same comment as last time this was submitted:

> @@ -2303,6 +2304,8 @@ static struct pci_driver spider_net_driv
>   */
>  static int __init spider_net_init(void)
>  {
> +       printk("spidernet Version %s.\n",VERSION);
> +
>         if (rx_descriptors < SPIDER_NET_RX_DESCRIPTORS_MIN) {
>                 rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_MIN;
>                 pr_info("adjusting rx descriptors to %i.\n",

This is missing a printk level and a space character. More importantly,
you should not print the presence of the driver to the syslog, but
the presence of a device driven by it.

	Arnd <><