Subject: Re: [PATCH] enable RTAS /proc for PowerPC/CHRP platform

From: Christoph Hellwig <[email-masked]>
Date: Tue, 17 Oct 2006 15:22:43 +0200

> --- a/arch/powerpc/kernel/rtas-proc.c	2006-10-14 05:34:03.000000000 +0200
> +++ b/arch/powerpc/kernel/rtas-proc.c	2006-10-16 10:46:16.000000000 +0200
> @@ -253,43 +253,70 @@ static void get_location_code(struct seq
>  static void check_location_string(struct seq_file *m, char *c);
>  static void check_location(struct seq_file *m, char *c);
>  
> +#ifdef CONFIG_PPC64
> +#define PROCRTAS_ROOT "ppc64"
> +#else
> +#define PROCRTAS_ROOT "ppc"

Please don't do any pathname changes.  Even if ppc64 isn't correct it's
what applications expect and what we should provide for a coherent user
interface.

> -	if (!machine_is(pseries))
> +	if ( ! ( machine_is(pseries) || machine_is(chrp) ) )
>  		return -ENODEV;

This should be the only change you need, and it should follow kernel
coding style, aka:

	if (!machine_is(pseries) && !machine_is(chrp))
		return -ENODEV;

>  	rtas_node = of_find_node_by_name(NULL, "rtas");
>  	if (rtas_node == NULL)
>  		return -ENODEV;

And given this check I wonder why we need the platform check at all.  It
should be safe to just remove it.