Subject: Re: [PATCH] enable RTAS /proc for PowerPC/CHRP platform

From: Arnd Bergmann <[email-masked]>
Date: Wed, 18 Oct 2006 00:22:23 +0200

On Tuesday 17 October 2006 15:22, Christoph Hellwig wrote:
> > =A0=A0=A0=A0=A0=A0rtas_node =3D of_find_node_by_name(NULL, "rtas");
> > =A0=A0=A0=A0=A0=A0if (rtas_node =3D=3D NULL)
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return -ENODEV;
>=20
> And given this check I wonder why we need the platform check at all. =A0It
> should be safe to just remove it.
>=20

One difference would be that it triggers on machines running SLOF (QS20,=20
some JS20/JS21) and maybe some older Macs, which is probably a good
thing.

I wonder if it should be a little stricter though:

> 	rtas_node =3D of_find_node_by_path("/rtas");
>	if (!rtas_node)
>		return -ENODEV;

In case there is a node called "rtas" somewhere else.

	Arnd <><