From: Arnd Bergmann <arnd.bergmann@de•ibm.com>
To: linuxppc-dev@ozlabs•org
Cc: "cbe-oss-dev@ozlabs•org" <cbe-oss-dev@ozlabs•org>
Subject: Re: [PATCH] powerpc: Support for MPIC on native cell
Date: Thu, 19 Oct 2006 16:38:50 +0200 [thread overview]
Message-ID: <200610191638.50652.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <1160984707.22522.64.camel@localhost.localdomain>
On Monday 16 October 2006 09:45, Benjamin Herrenschmidt wrote:
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0/* The MPIC driver will get=
everything it needs from the
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 * device-tree, just pass 0=
to all arguments
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 */
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0mpic =3D mpic_alloc(dn, 0, =
0, 0, 0, " MPIC =A0 =A0 ");
Do you expect future users to do the same and just pass zeroes?
If so, maybe we should add a small wrapper like
static inline struct mpic *mpic_probe(struct device_node *dn)
{
return mpic_alloc(dn, 0, 0, 0, 0, " MPIC ");
}
in <asm/mpic.h>
Arnd <><
next prev parent reply other threads:[~2006-10-19 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 7:45 [PATCH] powerpc: Support for MPIC on native cell Benjamin Herrenschmidt
2006-10-19 14:38 ` Arnd Bergmann [this message]
2006-10-19 23:40 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610191638.50652.arnd.bergmann@de.ibm.com \
--to=arnd.bergmann@de$(echo .)ibm.com \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox