Subject: Re: [PATCH 2/3] spufs: fix another off-by-one bug in mbox_read

From: Arnd Bergmann <[email-masked]>
Date: Tue, 24 Oct 2006 21:07:43 +0200

On Tuesday 24 October 2006 20:42, Pekka Enberg wrote:
> On 10/24/06, Arnd Bergmann <[email-masked]> wrote:
> > =A0 =A0 =A0 =A0 spu_acquire(ctx);
> > - =A0 =A0 =A0 for (count =3D 0; count <=3D len; count +=3D 4, udata++) {
> > + =A0 =A0 =A0 for (count =3D 0; (count + 4) <=3D len; count +=3D 4, uda=
ta++) {
>
> Wouldn't this be more obvious as
>
> =A0 for (count =3D 0, count < (len / 4); count++, udata++) {
>
> And then do count * 4 if you need the actual index somewhere. Hmm?

Count is the return value from a write() file operation. I find it
more readable to update that every time I do one put_user(), to
the exact value, than calculating the return code later.

	Arnd <><=20