Subject: Re: [PATCH 8/16] powerpc: add ps3 platform hvcalls

From: Christoph Hellwig <[email-masked]>
Date: Sat, 11 Nov 2006 12:22:39 +0100

On Sat, Nov 11, 2006 at 03:13:40AM +0100, Arnd Bergmann wrote:
> On Friday 10 November 2006 21:02, Geoff Levand wrote:
> > Adds the ps3pf hvcalls.
> > 
> > Signed-off-by: Geoff Levand <[email-masked]>
> 
> This one reminds of the inline hcall abstraction layer I did
> some time ago. The implementation in your patch is a lot
> less elegant than both the pseries in its current incarnation
> and the one that I did (IMHO). Any opinions on how we should
> proceed here?

Please try to reuse Arnd's code as much as possible.  What's in
this patch is more than ugly.