Subject: Re: [POWERPC] iSeries: fix slb.c for combined build

From: Olof Johansson <[email-masked]>
Date: Mon, 13 Nov 2006 01:03:30 -0600

On Mon, 13 Nov 2006 14:49:18 +1100 Stephen Rothwell <[email-masked]> wrote:

> -#ifndef CONFIG_PPC_ISERIES
> - {
> -	unsigned long lflags, vflags;
> +	if (!firmware_has_feature(FW_FEATURE_ISERIES)) {
> +		unsigned long lflags, vflags;
>  
> -	lflags = SLB_VSID_KERNEL | linear_llp;

It'll be a little tidier if you move the stab_rr setting (common code
at the bottom of the function) up above the test, and just return early
for iseries, instead of indenting everything an extra level.

-Olof