Subject: Re: [PATCH 7/16] powerpc: add support for ps3 platform

From: Arnd Bergmann <[email-masked]>
Date: Thu, 16 Nov 2006 17:35:15 +0100

On Friday 10 November 2006 21:02, Geoff Levand wrote:
> +static int __init ps3pf_probe(void)
> +{
> +=A0=A0=A0=A0=A0=A0=A0unsigned long htab_size;
> +
> +=A0=A0=A0=A0=A0=A0=A0pr_debug(" -> %s:%d\n", __func__, __LINE__);
> +
> +=A0=A0=A0=A0=A0=A0=A0powerpc_firmware_features |=3D FW_FEATURE_LPAR;
> +
> +=A0=A0=A0=A0=A0=A0=A0ps3pf_mm_init();
> +=A0=A0=A0=A0=A0=A0=A0ps3pf_mm_vas_create(&htab_size);
> +=A0=A0=A0=A0=A0=A0=A0ps3pf_hpte_init(htab_size);
> +
> +=A0=A0=A0=A0=A0=A0=A0pr_debug(" <- %s:%d\n", __func__, __LINE__);
> +=A0=A0=A0=A0=A0=A0=A0return 1;
> +}
> +

Your probe() function needs to check if you are actually running
on appropriate hardware and return 0 if not.

This currently breaks when booting a multiplatform kernel
on a non-ps3 system.

	Arnd <><