Subject: Re: [PATCH] Reorganise and then fixup the pseries cpu hotplug code

From: Stephen Rothwell <[email-masked]>
Date: Fri, 17 Nov 2006 15:31:05 +1100

One small nit ...

On Fri, 17 Nov 2006 14:36:35 +1100 Michael Ellerman <[email-masked]> wrote:
>
> +static int __init pseries_cpu_hotplug_init(void)
> +{
> +	rtas_stop_self_args.token = rtas_token("stop-self");
> +	qcss_tok = rtas_token("query-cpu-stopped-state");
> +
> +	if (rtas_stop_self_args.token == RTAS_UNKNOWN_SERVICE ||
> +			qcss_tok == RTAS_UNKNOWN_SERVICE)
> +		return 1;

initcall fucntions should return 0 or -<error>;  -ENODEV is ignored,
other nonzero values cause a log message if initcall debugging is enabled.

--
Cheers,
Stephen Rothwell                    [email-masked]
http://www.canb.auug.org.au/~sfr/