Subject: Re: [PATCH] Reorganise and then fixup the pseries cpu hotplug code

From: [email-masked] (Linas Vepstas)
Date: Fri, 17 Nov 2006 12:04:57 -0600

On Fri, Nov 17, 2006 at 02:36:35PM +1100, Michael Ellerman wrote:
> The pseries cpu hotplug code is currently spread between ./kernel/rtas.c,
> ./platforms/pseries/smp.c and ./platforms/pseries/setup.c. Some of it is
> not #ifdef CONFIG_HOTPLUG_CPU, but it should be.
> 
> So move all the cpu hotplug code into platforms/pseries/hotplug-cpu.c

Yes, much cleaner this way.

> +	/* Isolation and deallocation are definatly done by
                                        ^^^^^^^^^
typo

> +	 * drslot_chrp_cpu.  If they were not they would be
> +	 * done here.  Change isolate state to Isolate and
> +	 * change allocation-state to Unusable.
> +	 */
> +	paca[cpu].cpu_start = 0;

I can't figure out what the comment means with respect 
to this code ... 

--linas