Subject: Re: [PATCH] ps3: add vuart support

From: Arnd Bergmann <[email-masked]>
Date: Thu, 7 Dec 2006 19:37:21 +0100

On Thursday 07 December 2006 01:17, Geoff Levand wrote:
> Adds support for the PS3 virtual UART (vuart).  The vuart provides a
> bi-directional byte stream data link between logical partitions.

Looks good now, just a few minor comments:

> +struct ports_bmp
> +{
> +	u64 status;
> +	u64 unused[3];
> +} __attribute__ ((packed));

Do you really want to have this structure packed? It will produce
better code if it isn't.
For structure definitions, the common way is to write the opening
braces in the same line as the name, i.e.

struct ports_bmp {
	...
};

> +	default:
> +		BUG();
> +		*port_number = UINT_MAX;
> +		return -EINVAL;

No need to return after BUG(), the process is dead anyway. It should
probably be WARN_ON(1) instead of BUG().

> +static int get_rx_bytes_waiting(struct ps3_vuart_port_device *dev,
> +	unsigned long *bytes_waiting)
> +{
> +	int result = lv1_get_virtual_uart_param(dev->port_number,
> +		PARAM_RX_BYTES, bytes_waiting);
> +
> +	if (result)
> +		pr_debug("%s:%d: port_%u: rx_bytes failed: %s\n", __func__,
> +			__LINE__, dev->port_number, ps3_result(result));
> +
> +	pr_debug("%s:%d: port_%u: %lxh\n", __func__, __LINE__,
> +		dev->port_number, *bytes_waiting);

In places where you carry around a device pointer (probably most places),
it's nicer to use dev_dbg instead of pr_debug.

> +static int raw_write(struct ps3_vuart_port_device *dev, const void* buf,
> +	unsigned int bytes, unsigned long *bytes_written)

I'd give the function names a prefix, e.g. ps3_vuart_raw_write here, even
if they are static. This makes reading oops messages easier if you are
not familiar with the code, raw_write is a pretty common function name.

	Arnd <><