From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: paulus@samba•org
Subject: Re: [PATCH 8/15] Supporting PCI bus and base of I/O
Date: Tue, 12 Dec 2006 21:03:41 +0100 [thread overview]
Message-ID: <200612122103.41597.arnd@arndb.de> (raw)
In-Reply-To: <200612120338.kBC3c08S020556@toshiba.co.jp>
On Tuesday 12 December 2006 04:37, Ishizaki Kou wrote:
> This patch includes support for pci buses, base of Celleb specific
> devices, and etc. It works on of_platform bus.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki.co.jp>
The code looks good to me, I guess it could go in, except that
I really don't like the concept of faking a PCI bus device when
it's not actually there. I guess the EPCI part of this is
not controversial, so it would be good if you can split that
out into a separate patch that we can merge first.
Arnd <><
next prev parent reply other threads:[~2006-12-12 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 3:37 [PATCH 8/15] Supporting PCI bus and base of I/O Ishizaki Kou
2006-12-12 20:03 ` Arnd Bergmann [this message]
2006-12-12 20:49 ` Benjamin Herrenschmidt
2006-12-12 23:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612122103.41597.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox