Subject: Re: [PATCH 6/9] MPIC MSI allocator

From: Olof Johansson <[email-masked]>
Date: Wed, 13 Dec 2006 18:09:21 -0600

On Thu, 14 Dec 2006 10:25:44 +1100 Benjamin Herrenschmidt <[email-masked]> wrote:

> This code in MPIC currently is only ever used on U3/U4 and so that code
> reserves IRQs we know are used for U3/U4 internal IRQs and not available
> for HT interrupts (or MSIs). The code, then, does a second pass also
> exclusing all IRQs for all devices in the device-tree.
> 
> This is a "hack" that works until device-trees provide the right
> property we have defined for mpic to indicate what range of irqs is to
> be used for MSIs.

So make the platform register the range of (possibly) usable MSI
addresses instead of adding a nasty hack like that to the mpic driver.

Adding numeric constants like that (completely without comments as to
where they came from) in a function called
mpic_msi_auto_reserve_hwirqs() is just too ugly.

-Olof