Subject: Re: [PATCH 7/19] powerpc: hypervisor call numbers for Celleb

From: Christoph Hellwig <[email-masked]>
Date: Thu, 14 Dec 2006 18:32:35 +0100

On Thu, Dec 14, 2006 at 11:30:28AM +0900, Ishizaki Kou wrote:

> +
> +#ifdef	__ASSEMBLY__
> +#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((__v)<<60|(__x))
> +#elif defined(__powerpc64__)
> +#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((unsigned long)(__v)<<60|(__x))
> +#else
> +#define	__BEAT_ADD_VENDOR_ID(__x, __v)	((unsigned long long)(__v)<<60|(__x))
> +#endif

__powerpc64__ is always set for ppc64 compiles.

> +#define HV_allocate_memory (0)
> +#define HV_construct_virtual_address_space (2)

isn't HV_foo a little too generic?  Also no need for the braces around
the actual hvall numbers.