Subject: Re: [patch 0/1] ipmi: update: add autosensing of ipmi devices on powerpc using of device tree

From: Christian Krafft <[email-masked]>
Date: Tue, 19 Dec 2006 14:12:45 +0100

On Mon, 18 Dec 2006 22:52:07 +0100
Segher Boessenkool <[email-masked]> wrote:

> 
> info->io_regsize = regsize ? *regsize : DEFAULT_REGSIZE;
> 
> [Please note that fixes a copy/paste bug, too].

There is no DEFAULT_REGSIZE, all the code is using DEFAULT_REGSPACING as the default size.
It looks like the code assumes that the registers are located next to each other.
If thats not good, DEFAULT_REGSIZE should be introduced and used in all other probe functions as well.
That would be a seperate issue .

> Segher

-- 
Mit freundlichen Grüssen,
kind regards,

Christian Krafft
IBM Systems & Technology Group, 
Linux Kernel Development
IT Specialist