From: Vitaly Bordug <vbordug@ru•mvista.com>
To: bwarren@qstreams•com
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: Using fixed_phy with gianfar
Date: Wed, 10 Jan 2007 16:11:45 +0300 [thread overview]
Message-ID: <20070110161145.3d8b0c77@localhost.localdomain> (raw)
In-Reply-To: <1168385038.3964.44.camel@saruman.qstreams.net>
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
On Tue, 09 Jan 2007 18:23:58 -0500
Ben Warren wrote:
> Hello,
>
> My custom board has a couple of Ethernet switches attached via RvMII
> to the 'Gianfar' controllers of an MPC8349 CPU. We're using SPI
> instead of MDIO for control of the switches, and it looked like the
> 'fixed.c' PHY driver was the right thing to use. BTW, I'm using a
> 2.6.19 kernel.
>
> When I 'ifconfig up' one of the interfaces, the Gianfar driver tries
> to find a device on the MDIO bus of the variety bus_id:phy_id, where
> both bus_id and phy_id are numeric (defined in fsl_devices.h). The
> Fixed PHY driver creates devices on the MDIO bus with a bus_id that
> is a string, for example "fixed_1@100:1". Obviously, these will
> never match up. The very crude hack I made to get things working was
> to modify the Gianfar driver to match the "fixed" string.
>
> I'm sure I'm missing something, and am wondering what the correct way
> to do this is. Should I have board-specific code that creates PHY
> devices conforming to the Gianfar expectations instead of calling
> 'fixed_mdio_register_device()', or something else?
No, you do not miss - this is an issue. In fact MDIO bus was changed for numeric for gianfar-stuff, and has been remaining string for fs_enet. I think it makes sense to average this up, and will try to do that once will get 8349-mitx which is gianfar+ fixed user.
The point is that fixed should be updated to numeric MDIO address encoding. This has to come through netdev, so I'll try to get it fixed by the next merge window.
--
Sincerely, Vitaly
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-01-10 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 23:23 Using fixed_phy with gianfar Ben Warren
2007-01-10 13:11 ` Vitaly Bordug [this message]
2007-01-10 14:22 ` Ben Warren
2007-01-10 16:04 ` Vitaly Bordug
2007-01-10 17:01 ` Ben Warren
2007-01-10 22:41 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070110161145.3d8b0c77@localhost.localdomain \
--to=vbordug@ru$(echo .)mvista.com \
--cc=bwarren@qstreams$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox