Subject: Re: [PATCH 1/5] [POWERPC] cpm2: Updates for CPM2 pic

From: Vitaly Bordug <[email-masked]>
Date: Wed, 10 Jan 2007 23:13:22 +0300

On Wed, 10 Jan 2007 11:02:52 -0600
Kumar Gala wrote:

> 
> On Jan 9, 2007, at 7:11 PM, Vitaly Bordug wrote:
> 
> >
> > This contains important fixes for the CPM2 PIC code. Eliminated
> > CPM_IRQ_OFFSET, pulling the respective interrupt numbers from the  
> > interrupt
> > mapping. Updated devicetree files to reflect that. Changed direct
> > IC-related IO accesses to the IO accessors.
> >
> > Signed-off-by: Vitaly Bordug <[email-masked]>
> > ---
> 
> [snip]
> 
> > diff --git a/include/asm-powerpc/mpc8260.h b/include/asm-powerpc/ 
> > mpc8260.h
> > new file mode 100644
> > index 0000000..c2adcb0
> > --- /dev/null
> > +++ b/include/asm-powerpc/mpc8260.h
> > @@ -0,0 +1,32 @@
> > +/*
> > + * Since there are many different boards and no standard  
> > configuration,
> > + * we have a unique include file for each.  Rather than change
> > every
> > + * file that has to include MPC8260 configuration, they all include
> > + * this one and the configuration switching is done here.
> > + */
> > +#ifdef __KERNEL__
> > +#ifndef __ASM_PPC_MPC8260_H__
> > +#define __ASM_PPC_MPC8260_H__
> > +
> > +
> > +#ifdef CONFIG_8260
> > +
> > +#if defined(CONFIG_PQ2ADS) || defined (CONFIG_PQ2FADS)
> > +#include <platforms/82xx/pq2ads.h>
> > +#endif
> 
> What's defined in pq2ads.h that is needed by other code?
> 
holding CPM_MAP_ADDR -- not everywhere in the current code it could be pulled from the devtree.
Actually, I have it addressed, but that is pretty big mod that could not be called bugfix and will hopefully be merged in next window.

> > +
> > +#ifdef CONFIG_PCI_8260
> > +#include <platforms/82xx/m82xx_pci.h>
> > +#endif
> > +
> > +#ifndef _ISA_MEM_BASE
> > +#define _ISA_MEM_BASE   0
> > +#endif
> > +
> > +#ifndef PCI_DRAM_OFFSET
> > +#define PCI_DRAM_OFFSET 0
> > +#endif
> > +
> > +#endif /* CONFIG_8260 */
> > +#endif /* !__ASM_PPC_MPC8260_H__ */
> > +#endif /* __KERNEL__ */
> > _______________________________________________
> > Linuxppc-dev mailing list
> > [email-masked]
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
>