Subject: Re: [PATCH 3/5] [FS_ENET] OF-related update for FEC and SCC MAC's

From: Vitaly Bordug <[email-masked]>
Date: Wed, 10 Jan 2007 23:14:21 +0300

On Wed, 10 Jan 2007 11:07:58 -0600
Kumar Gala wrote:

> 
> On Jan 9, 2007, at 7:11 PM, Vitaly Bordug wrote:
> 
> >
> > Updated direct resource pass with ioremap call, make it grant  
> > proper IRQ
> > mapping, stuff incompatible with the new approach were
> > respectively put  under
> > #ifndef CONFIG_PPC_MERGE.
> >
> > Signed-off-by: Vitaly Bordug <[email-masked]>
> > ---
> >
> >  drivers/net/fs_enet/mac-fec.c |   13 +++++++++----
> >  drivers/net/fs_enet/mac-scc.c |    6 ++++--
> >  drivers/net/phy/fixed.c       |    2 +-
> >  3 files changed, 14 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/fs_enet/mac-fec.c b/drivers/net/fs_enet/ 
> > mac-fec.c
> > index c2c5fd4..474d6d7 100644
> > --- a/drivers/net/fs_enet/mac-fec.c
> > +++ b/drivers/net/fs_enet/mac-fec.c
> > @@ -104,9 +104,9 @@ static int do_pd_setup(struct fs_enet_private  
> > *fep)
> >  	fep->interrupt = platform_get_irq_byname(pdev,"interrupt");
> >  	if (fep->interrupt < 0)
> >  		return -EINVAL;
> > -	
> > +
> >  	r = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> > "regs");
> > -	fep->fec.fecp =(void*)r->start;
> > +	fep->fec.fecp = (void *)ioremap(r->start, r->end -
> > r->start + 1);
> 
> you should get rid of the (void *) cast
> 

Here and below: 
Agreed; will fix and respin.

Thanks, 
Vitaly