Subject: Re: [patch][5/5] powerpc: Add the general support for Embedded Floating-Point instructions

From: Christoph Hellwig <[email-masked]>
Date: Fri, 12 Jan 2007 10:52:13 +0100

On Fri, Jan 12, 2007 at 01:31:02PM +0800, [email-masked] wrote:
> +ifeq ($(CONFIG_SPE),y)
> +ifneq ($(CONFIG_MATH_EMULATION),y)
> +core-y				+= arch/powerpc/math-emu/
> +endif
> +endif
>  core-$(CONFIG_MATH_EMULATION)	+= arch/powerpc/math-emu/

This statement doesn't make any sense.  I guess you always want to
build arch/powerpc/math-emu if CONFIG_SPE is set, right?  The proper
way to do that is to force CONFIG_MATH_EMULATION in the Kconfig.

Then again we need a really good explanation why CONFIG_SPE should
force the math emulation to be built.