Subject: Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb

From: Anton Blanchard <[email-masked]>
Date: Sat, 13 Jan 2007 23:46:38 +1100

Hi,

Just a few suggestions.

> +#define	HCALL_MEDIUM	or 	2,2,2

Doesnt look like this is used.

> +#define	HVSC	.long	0x44000022

Could you pick this up from the define in include/asm-powerpc instead?

> +#define	LOAD_CONST64(r, const)					\
> +	lis	r, ((const)>>48)&0xFFFF;			\
> +	ori	r, r, ((const)>>32)&0xFFFF;			\
> +	rldicr	r, r, 32, 31;					\
> +	oris	r, r, ((const)>>16)&0xFFFF;			\
> +	ori	r, r, ((const)>>0)&0xFFFF

It doesnt look like this is used either.

Anton